lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 12 Aug 2022 18:48:20 +0300 From: Sergei Antonov <saproj@...il.com> To: netdev@...r.kernel.org Cc: Sergei Antonov <saproj@...il.com>, Jakub Kicinski <kuba@...nel.org>, Pavel Skripkin <paskripkin@...il.com>, "David S . Miller" <davem@...emloft.net>, Guobin Huang <huangguobin4@...wei.com>, Paolo Abeni <pabeni@...hat.com> Subject: [PATCH] net: moxa: inherit DMA masks to make dma_map_single() work dma_map_single() calls fail in moxart_mac_setup_desc_ring() and moxart_mac_start_xmit() which leads to an incessant output of this: [ 16.043925] moxart-ethernet 92000000.mac eth0: DMA mapping error [ 16.050957] moxart-ethernet 92000000.mac eth0: DMA mapping error [ 16.058229] moxart-ethernet 92000000.mac eth0: DMA mapping error To make dma_map_single() work, inherit DMA masks from the platform device. Signed-off-by: Sergei Antonov <saproj@...il.com> CC: Jakub Kicinski <kuba@...nel.org> CC: Pavel Skripkin <paskripkin@...il.com> CC: David S. Miller <davem@...emloft.net> CC: Guobin Huang <huangguobin4@...wei.com> CC: Paolo Abeni <pabeni@...hat.com> --- drivers/net/ethernet/moxa/moxart_ether.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/moxa/moxart_ether.c b/drivers/net/ethernet/moxa/moxart_ether.c index a3214a762e4b..de99211d85c2 100644 --- a/drivers/net/ethernet/moxa/moxart_ether.c +++ b/drivers/net/ethernet/moxa/moxart_ether.c @@ -537,6 +537,10 @@ static int moxart_mac_probe(struct platform_device *pdev) ndev->priv_flags |= IFF_UNICAST_FLT; ndev->irq = irq; + /* Inherit the DMA masks from the platform device */ + ndev->dev.dma_mask = p_dev->dma_mask; + ndev->dev.coherent_dma_mask = p_dev->coherent_dma_mask; + SET_NETDEV_DEV(ndev, &pdev->dev); ret = register_netdev(ndev); -- 2.32.0
Powered by blists - more mailing lists