lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 12 Aug 2022 19:56:11 +0200 From: Andrew Lunn <andrew@...n.ch> To: Sergei Antonov <saproj@...il.com> Cc: netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>, Pavel Skripkin <paskripkin@...il.com>, "David S . Miller" <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>, Florian Fainelli <f.fainelli@...il.com> Subject: Re: [PATCH v2] net: moxa: pass pdev instead of ndev to DMA functions On Fri, Aug 12, 2022 at 08:13:39PM +0300, Sergei Antonov wrote: > dma_map_single() calls fail in moxart_mac_setup_desc_ring() and > moxart_mac_start_xmit() which leads to an incessant output of this: > > [ 16.043925] moxart-ethernet 92000000.mac eth0: DMA mapping error > [ 16.050957] moxart-ethernet 92000000.mac eth0: DMA mapping error > [ 16.058229] moxart-ethernet 92000000.mac eth0: DMA mapping error > > Passing pdev to DMA is a common approach among net drivers. > > Changes in v2: > - Reject an approach to inherit DMA masks from the platform device. > > Signed-off-by: Sergei Antonov <saproj@...il.com> > Suggested-by: Andrew Lunn <andrew@...n.ch> > CC: Jakub Kicinski <kuba@...nel.org> > CC: Pavel Skripkin <paskripkin@...il.com> > CC: David S. Miller <davem@...emloft.net> > CC: Paolo Abeni <pabeni@...hat.com> > CC: Florian Fainelli <f.fainelli@...il.com> Reviewed-by: Andrew Lunn <andrew@...n.ch> Andrew
Powered by blists - more mailing lists