lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 12 Aug 2022 16:55:16 -0700 From: Jakub Kicinski <kuba@...nel.org> To: Cong Wang <xiyou.wangcong@...il.com> Cc: netdev@...r.kernel.org, bpf@...r.kernel.org, Cong Wang <cong.wang@...edance.com>, Eric Dumazet <edumazet@...gle.com>, John Fastabend <john.fastabend@...il.com>, Jakub Sitnicki <jakub@...udflare.com> Subject: Re: [Patch net v2 3/4] tcp: refactor tcp_read_skb() a bit On Sun, 7 Aug 2022 20:31:05 -0700 Cong Wang wrote: > From: Cong Wang <cong.wang@...edance.com> > > As tcp_read_skb() only reads one skb at a time, the while loop is > unnecessary, we can turn it into an if. This also simplifies the > code logic. I think Eric is AFK so we should just apply these, they LGTM. One minor nit below. > --- a/net/ipv4/tcp.c > +++ b/net/ipv4/tcp.c > @@ -1761,27 +1761,18 @@ int tcp_read_skb(struct sock *sk, skb_read_actor_t recv_actor) > if (sk->sk_state == TCP_LISTEN) > return -ENOTCONN; > > - while ((skb = tcp_recv_skb(sk, seq, &offset)) != NULL) { > - int used; > - > + skb = tcp_recv_skb(sk, seq, &offset); > + if (skb) { if (!skb) return 0; ?
Powered by blists - more mailing lists