lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 12 Aug 2022 11:54:43 +0200 From: Jakub Sitnicki <jakub@...udflare.com> To: Jakub Kicinski <kuba@...nel.org> Cc: netdev@...r.kernel.org, kernel-team@...udflare.com, van fantasy <g1042620637@...il.com> Subject: Re: [PATCH net] l2tp: Serialize access to sk_user_data with sock lock On Thu, Aug 11, 2022 at 10:23 AM -07, Jakub Kicinski wrote: > On Wed, 10 Aug 2022 12:28:48 +0200 Jakub Sitnicki wrote: >> Fixes: fd558d186df2 ("l2tp: Split pppol2tp patch into separate l2tp and ppp parts") > > That tag immediately sets off red flags. Please find the commit where > to code originates, not where it was last moved. The code move happened in v2.6.35. There's no point in digging further, IMHO. > >> Reported-by: van fantasy <g1042620637@...il.com> >> Tested-by: van fantasy <g1042620637@...il.com> > > Can we get real names? Otherwise let's just drop those tags. > I know that the legal name requirement is only for S-o-b tags, > technically, but it feels silly. I don't make the rules. There is already a precendent in the git log: commit 5c835bb142d4013c2ab24bff5ae9f6709a39cbcf Author: Paolo Abeni <pabeni@...hat.com> Date: Fri Jul 8 16:36:09 2022 -0700 mptcp: fix subflow traversal at disconnect time At disconnect time the MPTCP protocol traverse the subflows list closing each of them. In some circumstances - MPJ subflow, passive MPTCP socket, the latter operation can remove the subflow from the list, invalidating the current iterator. Address the issue using the safe list traversing helper variant. Reported-by: van fantasy <g1042620637@...il.com> Fixes: b29fcfb54cd7 ("mptcp: full disconnect implementation") Tested-by: Matthieu Baerts <matthieu.baerts@...sares.net> Reviewed-by: Mat Martineau <mathew.j.martineau@...ux.intel.com> Signed-off-by: Paolo Abeni <pabeni@...hat.com> Signed-off-by: Mat Martineau <mathew.j.martineau@...ux.intel.com> Signed-off-by: David S. Miller <davem@...emloft.net>
Powered by blists - more mailing lists