netdev - Re: [PATCH v2] wifi: cfg80211: Fix UAF in ieee80211_scan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 12 Aug 2022 17:27:58 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Siddh Raman Pant <code@...dh.me>
Cc:     johannes berg <johannes@...solutions.net>,
        "david s. miller" <davem@...emloft.net>,
        eric dumazet <edumazet@...gle.com>,
        jakub kicinski <kuba@...nel.org>,
        paolo abeni <pabeni@...hat.com>,
        netdev <netdev@...r.kernel.org>,
        syzbot+6cb476b7c69916a0caca 
        <syzbot+6cb476b7c69916a0caca@...kaller.appspotmail.com>,
        linux-wireless <linux-wireless@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        syzbot+f9acff9bf08a845f225d 
        <syzbot+f9acff9bf08a845f225d@...kaller.appspotmail.com>,
        syzbot+9250865a55539d384347 
        <syzbot+9250865a55539d384347@...kaller.appspotmail.com>,
        linux-kernel-mentees 
        <linux-kernel-mentees@...ts.linuxfoundation.org>
Subject: Re: [PATCH v2] wifi: cfg80211: Fix UAF in ieee80211_scan_rx()

On Fri, Aug 12, 2022 at 08:03:05PM +0530, Siddh Raman Pant wrote:
> On Fri, 12 Aug 2022 17:45:58 +0530  Greg KH  wrote:
> > The merge window is for new features to be added, bugfixes can be merged
> > at any point in time, but most maintainers close their trees until after
> > the merge window is closed before accepting new fixes, like this one.
> > 
> > So just relax, wait another week or so, and if there's no response,
> > resend it then.
> > 
> 
> Okay, sure.
> 
> > Personally, this patch seems very incorrect, but hey, I'm not the wifi
> > subsystem maintainer :)
> 
> Why do you think so?

rcu just delays freeing of an object, you might just be delaying the
race condition.  Just moving a single object to be freed with rcu feels
very odd if you don't have another reference somewhere.

Anyway, I don't know this codebase, so I could be totally wrong.

greg k-h