netdev - RE: [PATCH 2/2] Revert "mlxsw: core: Add the hottest thermal zone detection"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BL1PR12MB5377BB6CC118BBBA0B8403E4AF699@BL1PR12MB5377.namprd12.prod.outlook.com>
Date:   Sun, 14 Aug 2022 07:42:36 +0000
From:   Vadim Pasternak <vadimp@...dia.com>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>,
        "rafael@...nel.org" <rafael@...nel.org>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Ido Schimmel <idosch@...dia.com>,
        Petr Machata <petrm@...dia.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Subject: RE: [PATCH 2/2] Revert "mlxsw: core: Add the hottest thermal zone
 detection"



> -----Original Message-----
> From: Daniel Lezcano <daniel.lezcano@...aro.org>
> Sent: Friday, August 5, 2022 7:07 PM
> To: Vadim Pasternak <vadimp@...dia.com>; rafael@...nel.org
> Cc: davem@...emloft.net; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org; Ido Schimmel <idosch@...dia.com>; Petr Machata
> <petrm@...dia.com>; Eric Dumazet <edumazet@...gle.com>; Jakub
> Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>
> Subject: Re: [PATCH 2/2] Revert "mlxsw: core: Add the hottest thermal zone
> detection"
> 
> 
> Hi Vadim,
> 
> 
> On 04/08/2022 14:21, Vadim Pasternak wrote:
> >
> >
> >> -----Original Message-----
> >> From: Daniel Lezcano <daniel.lezcano@...aro.org>
> >> Sent: Monday, August 1, 2022 12:56 PM
> >> To: daniel.lezcano@...aro.org; rafael@...nel.org
> >> Cc: Vadim Pasternak <vadimp@...dia.com>; davem@...emloft.net;
> >> netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Ido Schimmel
> >> <idosch@...dia.com>; Petr Machata <petrm@...dia.com>; Eric Dumazet
> >> <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo
> Abeni
> >> <pabeni@...hat.com>
> >> Subject: [PATCH 2/2] Revert "mlxsw: core: Add the hottest thermal
> >> zone detection"
> >>
> >> This reverts commit 6f73862fabd93213de157d9cc6ef76084311c628.
> >>
> >> As discussed in the thread:
> >>
> >> https://lore.kernel.org/all/f3c62ebe-7d59-c537-a010-
> >> bff366c8aeba@...aro.org/
> >>
> >> the feature provided by commits 2dc2f760052da and 6f73862fabd93 is
> >> actually already handled by the thermal framework via the cooling
> >> device state aggregation, thus all this code is pointless.
> >>
> >> The revert conflicts with the following changes:
> >>   - 7f4957be0d5b8: thermal: Use mode helpers in drivers
> >>   - 6a79507cfe94c: mlxsw: core: Extend thermal module with per QSFP
> >> module thermal zones
> >>
> >> These conflicts were fixed and the resulting changes are in this patch.
> >>
> >> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
> > Tested-by: Vadim Pasternak <vadimp@...dia.com>
> 
> Thanks for testing
> 
> > Daniel,
> > Could you, please, re-base the patch on top of net-next as Jakub
> mentioned?
> > Or do you want me to do it?
> 
> It is fine, I can do it. The conflict is trivial.
> 
> However, I would have preferred to have the patch in my tree so I can
> continue the consolidation work.
> 
> Is it ok if I pick the patch and the conflict being simple, that can be handle at
> merge time, no?

Hi Daniel,

Sorry for the delay.

Yes, it is OK. There are no plans to make changes in 'core_thermal.c' module
In current cycle, so it should be fine.

Thanks,
Vadim.

> 
> > There is also redundant blank line in this patch:
> >
> 	&mlxsw_thermal_module_ops,
> > +
> >
> 	&mlxsw_thermal_params,
> 
> Yeah, thanks.
> 
> --
> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
> 
> Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-
> blog/> Blog