netdev - RE: [PATCH v2 1/2] fs: Export __receive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220816174237.99392-1-kuniyu@amazon.com>
Date:   Tue, 16 Aug 2022 10:42:37 -0700
From:   Kuniyuki Iwashima <kuniyu@...zon.com>
To:     <david.laight@...lab.com>
CC:     <davem@...emloft.net>, <edumazet@...gle.com>, <kuniyu@...zon.com>,
        <netdev@...r.kernel.org>, <tkhai@...ru>, <viro@...iv.linux.org.uk>
Subject: RE: [PATCH v2 1/2] fs: Export __receive_fd()

From:   David Laight <David.Laight@...LAB.COM>
Date:   Tue, 16 Aug 2022 17:29:53 +0000
> From: Kuniyuki Iwashima
> > Sent: 16 August 2022 18:15
> > 
> > From:   David Laight <David.Laight@...LAB.COM>
> > Date:   Tue, 16 Aug 2022 08:03:14 +0000
> > > From: Kirill Tkhai
> > > > Sent: 15 August 2022 22:15
> > > >
> > > > This is needed to make receive_fd_user() available in modules, and it will be used in next patch.
> > > >
> > > > Signed-off-by: Kirill Tkhai <tkhai@...ru>
> > > > ---
> > > > v2: New
> > > >  fs/file.c |    1 +
> > > >  1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/fs/file.c b/fs/file.c
> > > > index 3bcc1ecc314a..e45d45f1dd45 100644
> > > > --- a/fs/file.c
> > > > +++ b/fs/file.c
> > > > @@ -1181,6 +1181,7 @@ int __receive_fd(struct file *file, int __user *ufd, unsigned int o_flags)
> > > >  	__receive_sock(file);
> > > >  	return new_fd;
> > > >  }
> > > > +EXPORT_SYMBOL_GPL(__receive_fd);
> > >
> > > It doesn't seem right (to me) to be exporting a function
> > > with a __ prefix.
> > 
> > +1.
> > Now receive_fd() has inline and it's the problem.
> > Can we avoid this by moving receive_fd() in fs/file.c without inline and
> > exporting it?
> 
> It looks like it is receive_fd_user() that should be made a real
> function and then exported.

Right, I did wrong copy-and-paste :p


> __receive_fd() can then be static.
> The extra function call will be noise - and the compiler may
> well either tail-call it or inline different copies of __receive_fd()
> into the two callers.