netdev - Re: [PATCH v2 1/2] fs: Export __receive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c6c1d83c-abe1-3ad4-ccfe-1adf2d8cef1d@ya.ru>
Date:   Wed, 17 Aug 2022 00:59:20 +0300
From:   Kirill Tkhai <tkhai@...ru>
To:     David Laight <David.Laight@...LAB.COM>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>
Cc:     "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>
Subject: Re: [PATCH v2 1/2] fs: Export __receive_fd()

On 16.08.2022 11:03, David Laight wrote:
> From: Kirill Tkhai
>> Sent: 15 August 2022 22:15
>>
>> This is needed to make receive_fd_user() available in modules, and it will be used in next patch.
>>
>> Signed-off-by: Kirill Tkhai <tkhai@...ru>
>> ---
>> v2: New
>>  fs/file.c |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/fs/file.c b/fs/file.c
>> index 3bcc1ecc314a..e45d45f1dd45 100644
>> --- a/fs/file.c
>> +++ b/fs/file.c
>> @@ -1181,6 +1181,7 @@ int __receive_fd(struct file *file, int __user *ufd, unsigned int o_flags)
>>  	__receive_sock(file);
>>  	return new_fd;
>>  }
>> +EXPORT_SYMBOL_GPL(__receive_fd);
> 
> It doesn't seem right (to me) to be exporting a function
> with a __ prefix.

I don't think so.

$git grep "EXPORT_SYMBOL(__\|EXPORT_SYMBOL_GPL(__" | wc -l
1649