netdev - Re: [PATCH v2] net: moxa: pass pdev instead of ndev to DMA functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220815195631.1ca64b3d@kernel.org>
Date:   Mon, 15 Aug 2022 19:56:31 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Sergei Antonov <saproj@...il.com>
Cc:     netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
        Pavel Skripkin <paskripkin@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Jonas Jensen <jonas.jensen@...il.com>
Subject: Re: [PATCH v2] net: moxa: pass pdev instead of ndev to DMA
 functions

On Fri, 12 Aug 2022 20:13:39 +0300 Sergei Antonov wrote:
> dma_map_single() calls fail in moxart_mac_setup_desc_ring() and
> moxart_mac_start_xmit() which leads to an incessant output of this:
> 
> [   16.043925] moxart-ethernet 92000000.mac eth0: DMA mapping error
> [   16.050957] moxart-ethernet 92000000.mac eth0: DMA mapping error
> [   16.058229] moxart-ethernet 92000000.mac eth0: DMA mapping error
> 
> Passing pdev to DMA is a common approach among net drivers.

Thanks! I slapped 

Fixes: 6c821bd9edc9 ("net: Add MOXA ART SoCs ethernet driver")

on it when applying, please make sure to provide Fixes tags in
the future (and CC authors so they can review).