netdev - Re: [PATCH iproute2] ipstats: Define MIN function to fix undefined references

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220816190324.65bf01d7@hermes.local>
Date:   Tue, 16 Aug 2022 19:03:24 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Nick Hainke <vincent@...temli.org>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH iproute2] ipstats: Define MIN function to fix undefined
 references

On Sat,  6 Aug 2022 10:24:06 +0200
Nick Hainke <vincent@...temli.org> wrote:

> Fixes errors in the form of:
>  in function `ipstats_show_64':
>  <artificial>:(.text+0x4e30): undefined reference to `MIN'
> 
> Signed-off-by: Nick Hainke <vincent@...temli.org>
> ---
>  ip/ipstats.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/ip/ipstats.c b/ip/ipstats.c
> index 5cdd15ae..2f500fc8 100644
> --- a/ip/ipstats.c
> +++ b/ip/ipstats.c
> @@ -6,6 +6,10 @@
>  #include "utils.h"
>  #include "ip_common.h"
>  
> +#ifndef MIN
> +#define MIN(a, b) ((a) < (b) ? (a) : (b))
> +#endif
> +
>  struct ipstats_stat_dump_filters {
>  	/* mask[0] filters outer attributes. Then individual nests have their
>  	 * filtering mask at the index of the nested attribute

Not sure what non-standard headers you are using,
but this already addressed in main branch by:

commit cf6b60c504d4be5e1df2b2745e55d677967831d0
Author: Changhyeok Bae <changhyeok.bae@...il.com>
Date:   Tue Aug 9 04:01:05 2022 +0000

    ipstats: Add param.h for musl
    
    Fix build error for musl
    | /usr/src/debug/iproute2/5.19.0-r0/iproute2-5.19.0/ip/ipstats.c:231: undefined reference to `MIN'
    
    Signed-off-by: Changhyeok Bae <changhyeok.bae@...il.com>