netdev - Re: [PATCH iproute2] genl: modify the command output message of genl -h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 16 Aug 2022 19:06:23 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     jiangheng <15720603159@....com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH iproute2] genl: modify the command output message of
 genl -h

On Fri, 12 Aug 2022 15:21:15 +0800 (CST)
jiangheng <15720603159@....com> wrote:

> From f4709a324870822066b449bab89980dba8c8af79 Mon Sep 17 00:00:00 2001
> From: jinag <jinag12138@...il.com>
> Date: Thu, 14 Oct 2021 15:13:03 +0800
> Subject: [PATCH] genl: modify the command output of genl -h
> 
> after the modification, the command output is the same as that of man 8 genl and more readable.


iproute2 follows the kernel style and contribution rules.
This patch has multiple issues

$ checkpatch.pl ~/Downloads/iproute2-genl-modify-the-command-output-message-of-genl--h.patch 
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#58: 
after the modification, the command output is the same as that of man 8 genl and more readable.

ERROR: code indent should use tabs where possible
#77: FILE: genl/genl.c:102:
+               "Usage: genl [ OPTIONS ] OBJECT [help]\n"$

WARNING: please, no spaces at the start of a line
#77: FILE: genl/genl.c:102:
+               "Usage: genl [ OPTIONS ] OBJECT [help]\n"$

ERROR: code indent should use tabs where possible
#78: FILE: genl/genl.c:103:
+               "where  OBJECT := { ctrl CTRL_OPTS }\n"$

WARNING: please, no spaces at the start of a line
#78: FILE: genl/genl.c:103:
+               "where  OBJECT := { ctrl CTRL_OPTS }\n"$

ERROR: code indent should use tabs where possible
#79: FILE: genl/genl.c:104:
+               "       OPTIONS := { -s[tatistics] | -d[etails] | -r[aw] | -V[ersion] | -h[elp] }\n"$

WARNING: please, no spaces at the start of a line
#79: FILE: genl/genl.c:104:
+               "       OPTIONS := { -s[tatistics] | -d[etails] | -r[aw] | -V[ersion] | -h[elp] }\n"$

ERROR: code indent should use tabs where possible
#80: FILE: genl/genl.c:105:
+               "       CTRL_OPTS := { help | list | monitor | get PARMS }\n"$

WARNING: please, no spaces at the start of a line
#80: FILE: genl/genl.c:105:
+               "       CTRL_OPTS := { help | list | monitor | get PARMS }\n"$

ERROR: code indent should use tabs where possible
#81: FILE: genl/genl.c:106:
+               "       PARMS := { name NAME | id ID }\n");$

WARNING: please, no spaces at the start of a line
#81: FILE: genl/genl.c:106:
+               "       PARMS := { name NAME | id ID }\n");$

ERROR: Missing Signed-off-by: line(s)