netdev - Re: [PATCH net v2] l2tp: Serialize access to sk_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220817085118.0c45c690@kernel.org>
Date:   Wed, 17 Aug 2022 08:51:18 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jakub Sitnicki <jakub@...udflare.com>
Cc:     netdev@...r.kernel.org, kernel-team@...udflare.com,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Haowei Yan <g1042620637@...il.com>,
        Tom Parkin <tparkin@...alix.com>
Subject: Re: [PATCH net v2] l2tp: Serialize access to sk_user_data with sock
 lock

On Wed, 17 Aug 2022 16:33:33 +0200 Jakub Sitnicki wrote:
> > Note to other netdev maintainers that based on the discussion about 
> > the reuseport locking it's unclear whether we shouldn't also take 
> > the callback lock...  
> 
> You're right. reuseport_array, psock, and kcm protect sk_user_data with
> the callback lock, not the sock lock. Need to fix it.

Where 'it' == current patch? Would you mind adding to the kdoc on
sk_user_data that it's protected by the callback lock while at it?