netdev - Re: [PATCH net] net: dsa: don't warn in dsa_port_set_state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABikg9waS7B4en3QXyY5F6g03iBgxVjRCnhgs4EF9mGjv2bpqw@mail.gmail.com>
Date:   Wed, 17 Aug 2022 10:57:43 +0300
From:   Sergei Antonov <saproj@...il.com>
To:     Vladimir Oltean <vladimir.oltean@....com>
Cc:     netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net] net: dsa: don't warn in dsa_port_set_state_now() when
 driver doesn't support it

On Tue, 16 Aug 2022 at 23:14, Vladimir Oltean <vladimir.oltean@....com> wrote:
>
> ds->ops->port_stp_state_set() is, like most DSA methods, optional, and
> if absent, the port is supposed to remain in the forwarding state (as
> standalone). Such is the case with the mv88e6060 driver, which does not
> offload the bridge layer. DSA warns that the STP state can't be changed
> to FORWARDING as part of dsa_port_enable_rt(), when in fact it should not.
>
> The error message is also not up to modern standards, so take the
> opportunity to make it more descriptive.
>
> Fixes: fd3645413197 ("net: dsa: change scope of STP state setter")
> Reported-by: Sergei Antonov <saproj@...il.com>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Sergei Antonov <saproj@...il.com>