netdev - RE: [PATCH V4 2/3] arm64: dts: imx8ulp: Add the fec support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB9PR04MB8106B1570E12E5AFCC861FE0886A9@DB9PR04MB8106.eurprd04.prod.outlook.com>
Date:   Wed, 17 Aug 2022 10:10:28 +0000
From:   Wei Fang <wei.fang@....com>
To:     Shawn Guo <shawnguo@...nel.org>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>, Peng Fan <peng.fan@....com>,
        Jacky Bai <ping.bai@....com>,
        "sudeep.holla@....com" <sudeep.holla@....com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Aisheng Dong <aisheng.dong@....com>
Subject: RE: [PATCH V4 2/3] arm64: dts: imx8ulp: Add the fec support



> -----Original Message-----
> From: Shawn Guo <shawnguo@...nel.org>
> Sent: 2022年8月17日 17:47
> To: Wei Fang <wei.fang@....com>
> Cc: davem@...emloft.net; edumazet@...gle.com; kuba@...nel.org;
> pabeni@...hat.com; robh+dt@...nel.org; krzysztof.kozlowski+dt@...aro.org;
> s.hauer@...gutronix.de; netdev@...r.kernel.org; devicetree@...r.kernel.org;
> linux-kernel@...r.kernel.org; kernel@...gutronix.de; festevam@...il.com;
> dl-linux-imx <linux-imx@....com>; Peng Fan <peng.fan@....com>; Jacky Bai
> <ping.bai@....com>; sudeep.holla@....com;
> linux-arm-kernel@...ts.infradead.org; Aisheng Dong <aisheng.dong@....com>
> Subject: Re: [PATCH V4 2/3] arm64: dts: imx8ulp: Add the fec support
> 
> On Wed, Jul 27, 2022 at 12:38:52AM +1000, wei.fang@....com wrote:
> > From: Wei Fang <wei.fang@....com>
> >
> > Add the fec support on i.MX8ULP platforms.
> >
> > Signed-off-by: Wei Fang <wei.fang@....com>
> > Reviewed-by: Ahmad Fatoum <a.fatoum@...gutronix.de>
> > ---
> > V2 change:
> > Remove the external clocks which is related to specific board.
> > V3 change:
> > No change.
> > V4 Change:
> > Add Reviewed-by tag.
> > ---
> >  arch/arm64/boot/dts/freescale/imx8ulp.dtsi | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> > index 60c1b018bf03..3e8a1e4f0fc2 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> > @@ -16,6 +16,7 @@ / {
> >  	#size-cells = <2>;
> >
> >  	aliases {
> > +		ethernet0 = &fec;
> >  		gpio0 = &gpiod;
> >  		gpio1 = &gpioe;
> >  		gpio2 = &gpiof;
> > @@ -365,6 +366,16 @@ usdhc2: mmc@...f0000 {
> >  				bus-width = <4>;
> >  				status = "disabled";
> >  			};
> > +
> > +			fec: ethernet@...50000 {
> > +				compatible = "fsl,imx8ulp-fec", "fsl,imx6ul-fec",
> > +"fsl,imx6q-fec";
> 
> Since imx8ulp-fec is compatible with imx6ul-fec, what's the point of having
> imx6q-fec in there?  It can be dropped, I guess?
> 
Actually, I did drop this in version 1. But when I added the imx8ulp compatible
property to the fsl,fec.yaml, the maintainer expected imx8ulp to be compatible
with imx6ul and with imx6q. The patch of fsl,fec.yaml as follows:

--- a/Documentation/devicetree/bindings/net/fsl,fec.yaml
+++ b/Documentation/devicetree/bindings/net/fsl,fec.yaml
@@ -58,6 +58,11 @@ properties:
               - fsl,imx8qxp-fec
           - const: fsl,imx8qm-fec
           - const: fsl,imx6sx-fec
+      - items:
+          - enum:
+              - fsl,imx8ulp-fec
+          - const: fsl,imx6ul-fec
+          - const: fsl,imx6q-fec

For compliant with the fsl,fec.yaml, so I added the imx6q-fec in the later 
version. And the patch of the fsl,fec.yaml has already applied to the 
upstream kernel. Therefore, I think it does not matter if the imx6q-fec is
added.


> Shawn
> 
> > +				reg = <0x29950000 0x10000>;
> > +				interrupts = <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>;
> > +				interrupt-names = "int0";
> > +				fsl,num-tx-queues = <1>;
> > +				fsl,num-rx-queues = <1>;
> > +				status = "disabled";
> > +			};
> >  		};
> >
> >  		gpioe: gpio@...00080 {
> > --
> > 2.25.1
> >