netdev - Re: [PATCH] net: moxa: MAC address reading, generating, validity checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yv2kAO5l4uFcqh7D@lunn.ch>
Date:   Thu, 18 Aug 2022 04:29:20 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Sergei Antonov <saproj@...il.com>
Cc:     netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>,
        Vladimir Oltean <olteanv@...il.com>,
        Yang Yingliang <yangyingliang@...wei.com>,
        Pavel Skripkin <paskripkin@...il.com>,
        Yang Wei <yang.wei9@....com.cn>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>
Subject: Re: [PATCH] net: moxa: MAC address reading, generating, validity
 checking

> @@ -539,6 +533,11 @@ static int moxart_mac_probe(struct platform_device *pdev)
>  
>  	SET_NETDEV_DEV(ndev, &pdev->dev);
>  
> +	ret = platform_get_ethdev_address(p_dev, ndev);
> +	if (ret)
> +		eth_hw_addr_random(ndev);

You should look at the return value. It could be EPROBE_DEFFER,
because the EEPROM has not probed yet. You need to return this value,
so that the device core will probe other devices, including the
EEPROM, and then later reprobe this driver.

	Andrew