netdev - Re: [PATCH bpf] ip_tunnel: respect tunnel key's "flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220818133209.GA80579@Mem>
Date:   Thu, 18 Aug 2022 15:32:09 +0200
From:   Paul Chaignon <paul@...valent.com>
To:     Eyal Birger <eyal.birger@...il.com>, idosch@...dia.com,
        petrm@...dia.com, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, yoshfuji@...ux-ipv6.org,
        dsahern@...nel.org, razor@...ckwall.org, daniel@...earbox.net,
        kafai@...com
Cc:     netdev@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH bpf] ip_tunnel: respect tunnel key's "flow_flags" in IP
 tunnels

On Thu, Aug 18, 2022 at 10:41:18AM +0300, Eyal Birger wrote:
> Commit 451ef36bd229 ("ip_tunnels: Add new flow flags field to ip_tunnel_key")
> added a "flow_flags" member to struct ip_tunnel_key which was later used by
> the commit in the fixes tag to avoid dropping packets with sources that
> aren't locally configured when set in bpf_set_tunnel_key().
> 
> VXLAN and GENEVE were made to respect this flag, ip tunnels like IPIP and GRE
> were not.
> 
> This commit fixes this omission by making ip_tunnel_init_flow() receive
> the flow flags from the tunnel key in the relevant collect_md paths.
> 
> Fixes: b8fff748521c ("bpf: Set flow flag to allow any source IP in bpf_tunnel_key")
> Signed-off-by: Eyal Birger <eyal.birger@...il.com>
> ---
>  drivers/net/ethernet/mellanox/mlxsw/spectrum_span.c | 3 ++-
>  include/net/ip_tunnels.h                            | 4 +++-
>  net/ipv4/ip_gre.c                                   | 2 +-
>  net/ipv4/ip_tunnel.c                                | 7 ++++---
>  4 files changed, 10 insertions(+), 6 deletions(-)

Thanks for the fix!

Reviewed-by: Paul Chaignon <paul@...valent.com>