netdev - Re: [PATCH net-next 5/5] net: wwan: t7xx: Devlink documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 18 Aug 2022 17:43:20 +0300 (EEST)
From:   Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To:     m.chetan.kumar@...el.com
cc:     netdev@...r.kernel.org, kuba@...nel.org, davem@...emloft.net,
        johannes@...solutions.net, ryazanov.s.a@...il.com,
        loic.poulain@...aro.org, krishna.c.sudi@...el.com,
        m.chetan.kumar@...ux.intel.com, linuxwwan@...el.com,
        Devegowda Chandrashekar <chandrashekar.devegowda@...el.com>
Subject: Re: [PATCH net-next 5/5] net: wwan: t7xx: Devlink documentation

On Tue, 16 Aug 2022, m.chetan.kumar@...el.com wrote:

> From: M Chetan Kumar <m.chetan.kumar@...ux.intel.com>
> 
> Document the t7xx devlink commands usage for fw flashing &
> coredump collection.
> 
> Refer to t7xx.rst file for details.
> 
> Signed-off-by: M Chetan Kumar <m.chetan.kumar@...ux.intel.com>
> Signed-off-by: Devegowda Chandrashekar <chandrashekar.devegowda@...el.com>
> ---

> +``t7xx`` driver uses fastboot protocol for fw flashing. In the fw flashing
> +procedure, fastboot command's & response's are exchanged between driver

Using 's here seems incorrect.

> +and wwan device.

> +Note: component "value" represents the partition type to be programmed.

"value" is hard to understand here. I'd just say "component selects the 
partition type to be programmed."

> +      - The detailed modem components log are captured in this region

"components log are" seems inconsistent.


-- 
 i.