netdev - Re: [PATCH devicetree 1/3] arm64: dts: ls1028a: move DSA CPU port property to the common SoC dtsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <125791f71a27edd4c2d989125c55de3a@walle.cc>
Date:   Thu, 18 Aug 2022 16:45:43 +0200
From:   Michael Walle <michael@...le.cc>
To:     Vladimir Oltean <vladimir.oltean@....com>
Cc:     devicetree@...r.kernel.org, netdev@...r.kernel.org,
        Shawn Guo <shawnguo@...nel.org>, Li Yang <leoyang.li@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH devicetree 1/3] arm64: dts: ls1028a: move DSA CPU port
 property to the common SoC dtsi

Am 2022-08-18 16:05, schrieb Vladimir Oltean:
> Since the CPU port 4 of the switch is hardwired inside the SoC to go to
> the enetc port 2, this shouldn't be something that the board files need
> to set (but whether that CPU port is used or not is another 
> discussion).
> 
> So move the DSA "ethernet" property to the common dtsi.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> ---
>  .../boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts     | 1 -
>  arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var2.dts  | 1 -
>  arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts                | 1 -
>  arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi                   | 1 +
>  4 files changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git
> a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts
> index 6b575efd84a7..52ef2e8e5492 100644
> --- 
> a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts
> +++ 
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts
> @@ -104,7 +104,6 @@ &mscc_felix_port3 {
>  };
> 
>  &mscc_felix_port4 {
> -	ethernet = <&enetc_port2>;
>  	status = "okay";
>  };
> 
> diff --git
> a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var2.dts
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var2.dts
> index 330e34f933a3..37c20cb6c152 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var2.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var2.dts
> @@ -60,6 +60,5 @@ &mscc_felix_port1 {
>  };
> 
>  &mscc_felix_port4 {
> -	ethernet = <&enetc_port2>;
>  	status = "okay";
>  };
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> index e0cd1516d05b..7285bdcf2302 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> @@ -278,7 +278,6 @@ &mscc_felix_port3 {
>  };
> 
>  &mscc_felix_port4 {
> -	ethernet = <&enetc_port2>;
>  	status = "okay";
>  };
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 5627dd7734f3..3da105119d82 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -1157,6 +1157,7 @@ mscc_felix_port4: port@4 {
>  						reg = <4>;
>  						phy-mode = "internal";
>  						status = "disabled";
> +						ethernet = <&enetc_port2>;

same here, status should probably the last one.

except from that:
Acked-by: Michael Walle <michael@...le.cc>

> 
>  						fixed-link {
>  							speed = <2500>;