netdev - Re: [PATCH net] net: dsa: microchip: keep compatibility with device tree blobs with no phy-mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 18 Aug 2022 18:18:06 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Alvin Šipraga <ALSI@...g-olufsen.dk>
Cc:     Vladimir Oltean <vladimir.oltean@....com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Woojung Huh <woojung.huh@...rochip.com>,
        "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Russell King <linux@...linux.org.uk>,
        Michael Grzeschik <m.grzeschik@...gutronix.de>,
        Oleksij Rempel <linux@...pel-privat.de>,
        Thorsten Leemhuis <regressions@...mhuis.info>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        Craig McQueen <craig@...ueen.id.au>
Subject: Re: [PATCH net] net: dsa: microchip: keep compatibility with device
 tree blobs with no phy-mode

On Thu, Aug 18, 2022 at 03:06:44PM +0000, Alvin Šipraga wrote:
> Reviewed-by: Alvin Šipraga <alsi@...g-olufsen.dk>

Thanks.

> Some quick grepping shows at least a few other drivers which do not set
> PHY_INTERFACE_MODE_GMII for their ports with internal PHY:
> 
>     bcm_sf2
>     ar9331 (*)
>     lantiq_gswip
> 
> Should these be "fixed" too? Or only if somebody reports a regression?
> 
> (*) I note that ar9331 ought not to rely on DSA workarounds, per your
> other patchset, so I there is actually no need to "fix" that one, since
> the new validation you are introducing will require a phy-mode to be
> specified for those switches' ports anyway.

Note that my patch set which you are talking about
https://patchwork.kernel.org/project/netdevbpf/cover/20220818115500.2592578-1-vladimir.oltean@nxp.com/
only enforces phy-mode presence for CPU and DSA ports. Whereas internal
PHYs are more typical on user ports. So the problem is equally
applicable to ar9331, as long as it won't specify a phy-mode but rely on
DSA's assumption that user ports with lacking DT descriptions want to
connect to an internal PHY.

IDK, if I had infinite time I'd go fix every driver. I don't know why
some have GMII and some don't, and I'm not exactly keen to go study
every driver's subtleties unless a problem is reported.