netdev - [RFC PATCH net-next 07/10] net: dsa: remove "breaking chain" comment from dsa_switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220818154911.2973417-8-vladimir.oltean@nxp.com>
Date:   Thu, 18 Aug 2022 18:49:08 +0300
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     netdev@...r.kernel.org
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Kevin Hilman <khilman@...nel.org>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: [RFC PATCH net-next 07/10] net: dsa: remove "breaking chain" comment from dsa_switch_event

With the introduction of robust notifier chains, it is certainly no
longer true to simply say in dsa_switch_event() that the chain is
broken.

Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
---
 net/dsa/switch.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/net/dsa/switch.c b/net/dsa/switch.c
index e3a91f38c5db..37875960d3f0 100644
--- a/net/dsa/switch.c
+++ b/net/dsa/switch.c
@@ -987,10 +987,6 @@ static int dsa_switch_event(struct notifier_block *nb,
 		break;
 	}
 
-	if (err)
-		dev_dbg(ds->dev, "breaking chain for DSA event %lu (%d)\n",
-			event, err);
-
 	return notifier_from_errno(err);
 }
 
-- 
2.34.1