netdev - Re: [RFC PATCH net-next] net: dsa: qca8k: convert to regmap read/write API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220818165119.c5cgk5og7jhmzpo6@skbuf>
Date:   Thu, 18 Aug 2022 19:51:19 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Christian Marangi <ansuelsmth@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH net-next] net: dsa: qca8k: convert to regmap
 read/write API

On Sat, Aug 06, 2022 at 09:22:53PM +0200, Christian Marangi wrote:
> Convert qca8k to regmap read/write bulk API. The mgmt eth can write up
> to 16 bytes of data at times. Currently we use a custom function to do
> it but regmap now supports declaration of read/write bulk even without a
> bus.
> 
> Drop the custom function and rework the regmap function to this new
> implementation.
> 
> Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
> ---

Nothing in this change jumps out as wrong to me, but maybe you should
copy Mark Brown too when you submit it proper, as the first user of the
bulk regmap read/write over Ethernet, IIUC.