netdev - Re: [PATCH v16 mfd 8/8] mfd: ocelot: add support for the vsc7512 chip via spi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 18 Aug 2022 22:26:12 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Colin Foster <colin.foster@...advantage.com>
Cc:     Ido Schimmel <idosch@...sch.org>,
        Uwe Kleine-König <ukleinek@...ian.org>,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        netdev <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Terry Bowman <terry.bowman@....com>,
        Vladimir Oltean <vladimir.oltean@....com>,
        Wolfram Sang <wsa@...nel.org>,
        Microchip Linux Driver Support <UNGLinuxDriver@...rochip.com>,
        Steen Hegelund <Steen.Hegelund@...rochip.com>,
        Lars Povlsen <lars.povlsen@...rochip.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        "David S. Miller" <davem@...emloft.net>,
        Russell King <linux@...linux.org.uk>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Lee Jones <lee.jones@...aro.org>,
        katie.morris@...advantage.com,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Lee Jones <lee@...nel.org>
Subject: Re: [PATCH v16 mfd 8/8] mfd: ocelot: add support for the vsc7512 chip
 via spi

On Tue, Aug 16, 2022 at 6:20 PM Colin Foster
<colin.foster@...advantage.com> wrote:
>
> On Tue, Aug 16, 2022 at 11:52:53AM +0300, Andy Shevchenko wrote:
> > On Mon, Aug 15, 2022 at 5:35 PM Ido Schimmel <idosch@...sch.org> wrote:
> > >
> > > On Mon, Aug 15, 2022 at 07:19:13AM -0700, Colin Foster wrote:
> > > > Something is going on that I don't fully understand with <asm/byteorder.h>.
> > > > I don't quite see how ocelot-core is throwing all sorts of errors in x86
> > > > builds now:
> > > >
> > > > https://patchwork.hopto.org/static/nipa/667471/12942993/build_allmodconfig_warn/stderr
> > > >
> > > > Snippet from there:
> > > >
> > > > /home/nipa/nipa/tests/patch/build_32bit/build_32bit.sh: line 21: ccache gcc: command not found
> > > > ../drivers/mfd/ocelot-spi.c: note: in included file (through ../include/linux/bitops.h, ../include/linux/kernel.h, ../arch/x86/include/asm/percpu.h, ../arch/x86/include/asm/current.h, ../include/linux/sched.h, ...):
> > > > ../arch/x86/include/asm/bitops.h:66:1: warning: unreplaced symbol 'return'
> > > > ../drivers/mfd/ocelot-spi.c: note: in included file (through ../include/linux/bitops.h, ../include/linux/kernel.h, ../arch/x86/include/asm/percpu.h, ../arch/x86/include/asm/current.h, ../include/linux/sched.h, ...):
> > > > ../include/asm-generic/bitops/generic-non-atomic.h:29:9: warning: unreplaced symbol 'mask'
> > > > ../include/asm-generic/bitops/generic-non-atomic.h:30:9: warning: unreplaced symbol 'p'
> > > > ../include/asm-generic/bitops/generic-non-atomic.h:32:10: warning: unreplaced symbol 'p'
> > > > ../include/asm-generic/bitops/generic-non-atomic.h:32:16: warning: unreplaced symbol 'mask'
> > > > ../include/asm-generic/bitops/generic-non-atomic.h:27:1: warning: unreplaced symbol 'return'
> > > > ../drivers/mfd/ocelot-spi.c: note: in included file (through ../arch/x86/include/asm/bitops.h, ../include/linux/bitops.h, ../include/linux/kernel.h, ../arch/x86/include/asm/percpu.h, ../arch/x86/include/asm/current.h, ...):
> > > > ../include/asm-generic/bitops/instrumented-non-atomic.h:26:1: warning: unreplaced symbol 'return'
> > > >
> > > >
> > > > <asm/byteorder.h> was included in both drivers/mfd/ocelot-spi.c and
> > > > drivers/mfd/ocelot.h previously, though Andy pointed out there didn't
> > > > seem to be any users... and I didn't either. I'm sure there's something
> > > > I must be missing.
> > >
> > > I got similar errors in our internal CI yesterday. Fixed by compiling
> > > sparse from git:
> > > https://git.kernel.org/pub/scm/devel/sparse/sparse.git/commit/?id=0e1aae55e49cad7ea43848af5b58ff0f57e7af99
> > >
> > > The update is also available in the "testing" repo in case you are
> > > running Fedora 35 / 36:
> > > https://bodhi.fedoraproject.org/updates/FEDORA-2022-c58b53730f
> > > https://bodhi.fedoraproject.org/updates/FEDORA-2022-2bc333ccac
> >
> > Debian still produces the same errors which makes sparse useless.
>
> I haven't jumped into this one yet. But everything seems to be compiling
> and running in ARM.
>
> Do you think this is a false positive / unrelated to this patch? Or do
> you think this is a true error that I did wrong? I haven't been around
> for too many releases, so I'm not sure if this is common after an -rc1.

It's a sparse issue and Debian maintainer for sparse is not updating
it for some reasons...

-- 
With Best Regards,
Andy Shevchenko