[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20220818211521.169569-1-jacob.e.keller@intel.com>
Date: Thu, 18 Aug 2022 14:15:19 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: netdev@...r.kernel.org
Cc: Jacob Keller <jacob.e.keller@...el.com>,
Jonathan Corbet <corbet@....net>, Jiri Pirko <jiri@...dia.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
David Ahern <dsahern@...nel.org>,
Stephen Hemminger <stephen@...workplumber.org>
Subject: [iproute2-next 0/2] devlink: remove dl_argv_parse_put
This series removes the dl_argv_parse_put function which both parses the
command line arguments and places them into the netlink header.
This was originally sent as an RFC at
https://lore.kernel.org/netdev/20220805234155.2878160-1-jacob.e.keller@intel.com/
Since there is some ongoing work around policy code being generated from
YAML, I thought it best to wait on the devlink policy portion of this series
for now.
Jiri mentioned he wanted to base some work on top of this, so I am sending
just the cleanup patches.
The primary motivation for this is due to the fact that dl_argv_parse_put
requires a netlink header, meaning a command must have already been
prepared. This prevents addition of a different netlink command to get the
policy data, and thus prevents us from using this variant while checking
netlink policy.
Cc: Jacob Keller <jacob.e.keller@...el.com>
Cc: Jonathan Corbet <corbet@....net>
Cc: Jiri Pirko <jiri@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>
Cc: Eric Dumazet <edumazet@...gle.com>
Cc: Jakub Kicinski <kuba@...nel.org>
Cc: Paolo Abeni <pabeni@...hat.com>
Cc: David Ahern <dsahern@...nel.org>
Cc: Stephen Hemminger <stephen@...workplumber.org>
Cc: netdev@...r.kernel.org
Jacob Keller (2):
devlink: use dl_no_arg instead of checking dl_argc == 0
devlink: remove dl_argv_parse_put
devlink/devlink.c | 587 ++++++++++++++++++++++++++--------------------
1 file changed, 329 insertions(+), 258 deletions(-)
base-commit: 700a8991f05e6e37889101196a531cf82777bdf7
--
2.37.1.394.gc50926e1f488
Powered by blists - more mailing lists