netdev - Re: [PATCH v2 net 16/17] net: Fix a data-race around netdev_unregister_timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 18 Aug 2022 08:53:23 +0200
From:   Dmitry Vyukov <dvyukov@...gle.com>
To:     Kuniyuki Iwashima <kuniyu@...zon.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org,
        Marco Elver <elver@...gle.com>
Subject: Re: [PATCH v2 net 16/17] net: Fix a data-race around netdev_unregister_timeout_secs.

On Thu, 18 Aug 2022 at 05:57, Kuniyuki Iwashima <kuniyu@...zon.com> wrote:
>
> While reading netdev_unregister_timeout_secs, it can be changed
> concurrently.  Thus, we need to add READ_ONCE() to its reader.
>
> Fixes: 5aa3afe107d9 ("net: make unregister netdev warning timeout configurable")
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>
> ---
> CC: Dmitry Vyukov <dvyukov@...gle.com>

Thanks, Kuniyuki.
RIght, since it is a sysctl it can be changed concurrently.

Acked-by: Dmitry Vyukov <dvyukov@...gle.com>


> ---
>  net/core/dev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/core/dev.c b/net/core/dev.c
> index 8221322d86db..56c8b0921c9f 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -10284,7 +10284,7 @@ static struct net_device *netdev_wait_allrefs_any(struct list_head *list)
>                                 return dev;
>
>                 if (time_after(jiffies, warning_time +
> -                              netdev_unregister_timeout_secs * HZ)) {
> +                              READ_ONCE(netdev_unregister_timeout_secs) * HZ)) {
>                         list_for_each_entry(dev, list, todo_list) {
>                                 pr_emerg("unregister_netdevice: waiting for %s to become free. Usage count = %d\n",
>                                          dev->name, netdev_refcnt_read(dev));
> --
> 2.30.2
>