netdev - Re: [PATCH] netfilter: move from strlcpy with unused retval to strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yv9cya3UyvJsh0Ah@vergenet.net>
Date:   Fri, 19 Aug 2022 11:50:01 +0200
From:   Simon Horman <horms@...nel.org>
To:     Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc:     linux-kernel@...r.kernel.org,
        Pablo Neira Ayuso <pablo@...filter.org>,
        Jozsef Kadlecsik <kadlec@...filter.org>,
        Florian Westphal <fw@...len.de>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Julian Anastasov <ja@....bg>,
        netfilter-devel@...r.kernel.org, coreteam@...filter.org,
        netdev@...r.kernel.org, lvs-devel@...r.kernel.org
Subject: Re: [PATCH] netfilter: move from strlcpy with unused retval to
 strscpy

On Thu, Aug 18, 2022 at 11:02:24PM +0200, Wolfram Sang wrote:
> Follow the advice of the below link and prefer 'strscpy' in this
> subsystem. Conversion is 1:1 because the return value is not used.
> Generated by a coccinelle script.
> 
> Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>

Thanks Wolfram,

FWIIW, for the IPVS portion:

Reviewed-by: Simon Horman <horms@...ge.net.au>

> ---
>  net/netfilter/ipset/ip_set_core.c |  4 ++--
>  net/netfilter/ipvs/ip_vs_ctl.c    |  8 ++++----
>  net/netfilter/nf_log.c            |  4 ++--
>  net/netfilter/nf_tables_api.c     |  2 +-
>  net/netfilter/nft_osf.c           |  2 +-
>  net/netfilter/x_tables.c          | 20 ++++++++++----------
>  net/netfilter/xt_RATEEST.c        |  2 +-
>  7 files changed, 21 insertions(+), 21 deletions(-)

...