netdev - Re: [PATCH v8 1/3] vdpa: delete unreachable branch on vdpasim

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 19 Aug 2022 08:55:30 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     Eugenio Pérez <eperezma@...hat.com>
Cc:     virtualization <virtualization@...ts.linux-foundation.org>,
        "Michael S. Tsirkin" <mst@...hat.com>, kvm <kvm@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        netdev <netdev@...r.kernel.org>, ecree.xilinx@...il.com,
        "Dawar, Gautam" <gautam.dawar@....com>,
        Zhang Min <zhang.min9@....com.cn>,
        Pablo Cascon Katchadourian <pabloc@...inx.com>,
        "Uminski, Piotr" <Piotr.Uminski@...el.com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        "Kamde, Tanuj" <tanuj.kamde@....com>,
        Zhu Lingshan <lingshan.zhu@...el.com>,
        Martin Petrus Hubertus Habets <martinh@...inx.com>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Laurent Vivier <lvivier@...hat.com>,
        Martin Porter <martinpo@...inx.com>,
        Harpreet Singh Anand <hanand@...inx.com>,
        Eli Cohen <elic@...dia.com>, Cindy Lu <lulu@...hat.com>,
        Martin Habets <habetsm.xilinx@...il.com>,
        Parav Pandit <parav@...dia.com>,
        Longpeng <longpeng2@...wei.com>,
        Wu Zongyong <wuzongyong@...ux.alibaba.com>,
        Si-Wei Liu <si-wei.liu@...cle.com>,
        Stefano Garzarella <sgarzare@...hat.com>,
        Dinan Gunawardena <dinang@...inx.com>,
        Xie Yongji <xieyongji@...edance.com>
Subject: Re: [PATCH v8 1/3] vdpa: delete unreachable branch on vdpasim_suspend

On Thu, Aug 11, 2022 at 9:54 PM Eugenio Pérez <eperezma@...hat.com> wrote:
>
> It was a leftover from previous versions.
>
> Signed-off-by: Eugenio Pérez <eperezma@...hat.com>

Acked-by: Jason Wang <jasowang@...hat.com>

> ---
>  drivers/vdpa/vdpa_sim/vdpa_sim.c | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c
> index 213883487f9b..79a50edf8998 100644
> --- a/drivers/vdpa/vdpa_sim/vdpa_sim.c
> +++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c
> @@ -509,16 +509,9 @@ static int vdpasim_reset(struct vdpa_device *vdpa)
>  static int vdpasim_suspend(struct vdpa_device *vdpa)
>  {
>         struct vdpasim *vdpasim = vdpa_to_sim(vdpa);
> -       int i;
>
>         spin_lock(&vdpasim->lock);
>         vdpasim->running = false;
> -       if (vdpasim->running) {
> -               /* Check for missed buffers */
> -               for (i = 0; i < vdpasim->dev_attr.nvqs; ++i)
> -                       vdpasim_kick_vq(vdpa, i);
> -
> -       }
>         spin_unlock(&vdpasim->lock);
>
>         return 0;
> --
> 2.31.1
>