netdev - Re: [PATCH wpan-next 20/20] ieee802154: hwsim: Allow devices to be coordinators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220819191212.4503a6d9@xps-13>
Date:   Fri, 19 Aug 2022 19:12:12 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Alexander Aring <aahringo@...hat.com>
Cc:     Alexander Aring <alex.aring@...il.com>,
        Stefan Schmidt <stefan@...enfreihafen.org>,
        linux-wpan - ML <linux-wpan@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Network Development <netdev@...r.kernel.org>,
        David Girault <david.girault@...vo.com>,
        Romuald Despres <romuald.despres@...vo.com>,
        Frederic Blain <frederic.blain@...vo.com>,
        Nicolas Schodet <nico@...fr.eu.org>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH wpan-next 20/20] ieee802154: hwsim: Allow devices to be
 coordinators

Hi Alexander,

aahringo@...hat.com wrote on Sun, 10 Jul 2022 22:01:43 -0400:

> Hi,
> 
> On Fri, Jul 1, 2022 at 10:37 AM Miquel Raynal <miquel.raynal@...tlin.com> wrote:
> >
> > In order to be able to create coordinator interfaces, we need the
> > drivers to advertize that they support this type of interface. Fill in
> > the right bit in the hwsim capabilities to allow the creation of these
> > coordinator interfaces.
> >
> > Signed-off-by: Miquel Raynal <miquel.raynal@...tlin.com>
> > ---
> >  drivers/net/ieee802154/mac802154_hwsim.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/net/ieee802154/mac802154_hwsim.c b/drivers/net/ieee802154/mac802154_hwsim.c
> > index a5b9fc2fb64c..a678ede07219 100644
> > --- a/drivers/net/ieee802154/mac802154_hwsim.c
> > +++ b/drivers/net/ieee802154/mac802154_hwsim.c
> > @@ -776,6 +776,8 @@ static int hwsim_add_one(struct genl_info *info, struct device *dev,
> >         /* 950 MHz GFSK 802.15.4d-2009 */
> >         hw->phy->supported.channels[6] |= 0x3ffc00;
> >
> > +       hw->phy->supported.iftypes |= BIT(NL802154_IFTYPE_COORD);  
> 
> I think we can do that for more than one driver (except ca8210).

Yes of course. I can update this patch and make the change to all the
drivers except ca8210 indeed.

> What about the other iftypes?

The NODE type is set by default at initialization time:
net/mac802154/main.c-120-       /* always supported */
net/mac802154/main.c:121:       phy->supported.iftypes = BIT(NL802154_IFTYPE_NODE);

The MONITOR type is only set if the device supports the promiscuous
mode:
net/mac802154/main.c-255-       if (hw->flags & IEEE802154_HW_PROMISCUOUS)
net/mac802154/main.c:256:               local->phy->supported.iftypes |= BIT(NL802154_IFTYPE_MONITOR);

Which indeed makes echo to one of your other review, saying that we
should probably prevent the creation of MONITOR types if the device has
no promiscuous support.

Thanks,
Miquèl