netdev - Re: [PATCH v2 2/2] docs: netlink: basic introduction to Netlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 19 Aug 2022 14:54:48 -0600
From:   Jonathan Corbet <corbet@....net>
To:     Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com,
        Jakub Kicinski <kuba@...nel.org>,
        Jacob Keller <jacob.e.keller@...el.com>,
        johannes@...solutions.net, stephen@...workplumber.org,
        sdf@...gle.com, ecree.xilinx@...il.com, benjamin.poirier@...il.com,
        idosch@...sch.org, f.fainelli@...il.com, jiri@...nulli.us,
        dsahern@...nel.org, fw@...len.de, linux-doc@...r.kernel.org,
        jhs@...atatu.com, tgraf@...g.ch, svinota.saveliev@...il.com,
        rdunlap@...radead.org, mkubecek@...e.cz
Subject: Re: [PATCH v2 2/2] docs: netlink: basic introduction to Netlink

Jakub Kicinski <kuba@...nel.org> writes:

> Provide a bit of a brain dump of netlink related information
> as documentation. Hopefully this will be useful to people
> trying to navigate implementing YAML based parsing in languages
> we won't be able to help with.
>
> I started writing this doc while trying to figure out what
> it'd take to widen the applicability of YAML to good old rtnl,
> but the doc grew beyond that as it usually happens.
>
> In all honesty a lot of this information is new to me as I usually
> follow the "copy an existing example, drink to forget" process
> of writing netlink user space, so reviews will be much appreciated.
>
> Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> --
> Jon, I'm putting this in userspace-api/ I think it fits reasonably
> well there but please don't hesitate to suggest a better home.

That seems like a fine place for it - this is an addition that, I think,
a lot of people will welcome.

A couple of nits, feel free to ignore them:

 - Do you plan to add other netlink documents to that directory in the
   future?  If not, I'd just make a netlink.rst and not bother with the
   directory and index.rst.

 - I'm not sure that all the :c:member markup buys enough to be worth
   the clutter.

Regardless, should it be worth something:

Acked-by: Jonathan Corbet <corbet@....net>

Thanks for doing this; I've been meaning for years to reverse-engineer
netlink and write something like this, now I don't have to :)

jon