netdev - Re: [PATCH net-next] net: sched: remove duplicate check of user rights in qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0ba453c4-6baa-7915-cf22-5953556e5b13@huawei.com>
Date:   Fri, 19 Aug 2022 12:21:17 +0800
From:   shaozhengchao <shaozhengchao@...wei.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <jhs@...atatu.com>, <xiyou.wangcong@...il.com>, <jiri@...nulli.us>,
        <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
        <weiyongjun1@...wei.com>, <yuehaibing@...wei.com>
Subject: Re: [PATCH net-next] net: sched: remove duplicate check of user
 rights in qdisc



On 2022/8/19 11:44, Jakub Kicinski wrote:
> On Thu, 18 Aug 2022 15:25:00 +0800 Zhengchao Shao wrote:
>> -	if ((n->nlmsg_type != RTM_GETACTION) &&
>> -	    !netlink_capable(skb, CAP_NET_ADMIN))
>> -		return -EPERM;
> 
> This check is not network namespace capable, right?
> 
> We're probably fine making it namespace aware but it needs to be a
> separate change.

Hi Jakub:
	Thank you for your reply. I will add the wrong deletion back in V2. And 
I will also consider to make checking namespace aware in action function.

Zhengchao Shao