netdev - Re: [iproute2-next 2/2] devlink: remove dl_argv_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yv9JV52+COsNcyVU@nanopsycho>
Date:   Fri, 19 Aug 2022 10:27:03 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Jacob Keller <jacob.e.keller@...el.com>
Cc:     netdev@...r.kernel.org, Jonathan Corbet <corbet@....net>,
        Jiri Pirko <jiri@...dia.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        David Ahern <dsahern@...nel.org>,
        Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [iproute2-next 2/2] devlink: remove dl_argv_parse_put

Thu, Aug 18, 2022 at 11:15:21PM CEST, jacob.e.keller@...el.com wrote:
>The dl_argv_parse_put function is used to extract arguments from the
>command line and convert them to the appropriate netlink attributes. This
>function is a combination of calling dl_argv_parse and dl_put_opts.
>
>A future change is going to refactor dl_argv_parse to check the kernel's
>netlink policy for the command. This requires issuing another netlink
>message which requires calling dl_argv_parse before
>mnlu_gen_socket_cmd_prepare. Otherwise, the get policy command issued in
>dl_argv_parse would overwrite the prepared buffer.
>
>This conflicts with dl_argv_parse_put which requires being called after
>mnlu_gen_socket_cmd_prepare.
>
>Remove dl_argv_parse_put and replace it with appropriate calls to
>dl_argv_parse and dl_put_opts. This allows us to ensure dl_argv_parse is
>called before mnlu_gen_socket_cmd_prepare while dl_put_opts is called
>afterwards.
>
>Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>

Reviewed-by: Jiri Pirko <jiri@...dia.com>