netdev - RE: [PATCH 1/3] net/macsec: Add MACsec skb_metadata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM4PR12MB5357C54831EB8F1C9C982D90C96E9@DM4PR12MB5357.namprd12.prod.outlook.com>
Date:   Sun, 21 Aug 2022 11:12:00 +0000
From:   Raed Salem <raeds@...dia.com>
To:     Jakub Kicinski <kuba@...nel.org>,
        Lior Nahmanson <liorna@...dia.com>
CC:     "edumazet@...gle.com" <edumazet@...gle.com>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Saeed Mahameed <saeedm@...dia.com>
Subject: RE: [PATCH 1/3] net/macsec: Add MACsec skb_metadata_dst Tx Data path
 support

>-----Original Message-----
>From: Jakub Kicinski <kuba@...nel.org>
>Sent: Friday, August 19, 2022 7:09 AM
>To: Lior Nahmanson <liorna@...dia.com>
>Cc: edumazet@...gle.com; pabeni@...hat.com; davem@...emloft.net;
>netdev@...r.kernel.org; Raed Salem <raeds@...dia.com>; Saeed Mahameed
><saeedm@...dia.com>
>Subject: Re: [PATCH 1/3] net/macsec: Add MACsec skb_metadata_dst Tx Data
>path support
>
>External email: Use caution opening links or attachments
>
>
>On Thu, 18 Aug 2022 16:24:09 +0300 Lior Nahmanson wrote:
>> In the current MACsec offload implementation, MACsec interfaces shares
>> the same MAC address by default.
>> Therefore, HW can't distinguish from which MACsec interface the
>> traffic originated from.
>>
>> MACsec stack will use skb_metadata_dst to store the SCI value, which
>> is unique per MACsec interface, skb_metadat_dst will be used later by
>> the offloading device driver to associate the SKB with the
>> corresponding offloaded interface (SCI) to facilitate HW MACsec offload.
>
>struct macsec_tx_sc has a kdoc so you need to document the new field
>(md_dst).
Ack, will do as part of V2
>
>On a quick (sorry we're behind on patches this week) look I don't see the
>driver integration - is it coming later? Or there's already somehow a driver in
>the tree using this infra? Normally the infra should be in the same patchset as
>the in-tree user.
Driver integration series will be submitted later on
>
>Last thing - please CC some of the folks who worked on MACsec in the past,
>so we can get expert reviews, Antoine and Sabrina come to mind, look thru
>the git history please.
Ack, will be added starting form V2

Thanks for the review