lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <YwNtJAQlJVycijou@li-4a3a4a4c-28e5-11b2-a85c-a8d192c6f089.ibm.com> Date: Mon, 22 Aug 2022 13:48:52 +0200 From: Alexander Gordeev <agordeev@...ux.ibm.com> To: Wolfram Sang <wsa+renesas@...g-engineering.com>, linux-kernel@...r.kernel.org, Stefan Haberland <sth@...ux.ibm.com>, Jan Hoeppner <hoeppner@...ux.ibm.com>, Heiko Carstens <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>, Christian Borntraeger <borntraeger@...ux.ibm.com>, Sven Schnelle <svens@...ux.ibm.com>, Vineeth Vijayan <vneethv@...ux.ibm.com>, Peter Oberparleiter <oberpar@...ux.ibm.com>, Alexandra Winter <wintera@...ux.ibm.com>, Wenjia Zhang <wenjia@...ux.ibm.com>, Steffen Maier <maier@...ux.ibm.com>, Benjamin Block <bblock@...ux.ibm.com>, linux-s390@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH] s390: move from strlcpy with unused retval to strscpy On Mon, Aug 22, 2022 at 10:37:47AM +0200, Wolfram Sang wrote: > Hi Alexander, > > > Could you please explain why you skipped strlcpy() usage in > > drivers/s390/char/diag_ftp.c and drivers/s390/char/sclp_ftp.c? > > Sure. It is a bit hidden in $subject, but the key is to convert strlcpy > instances for now which do not check the return value. This is the > low-hanging fruit. > > Converting the other uses checking the return value needs to be done > manually and much more carfully. I wanted to this as a second step, but > if you prefer to have everything converted in one go, I can give your > subsystem a priority boost. Would you prefer that? A follow-up patch is also fine. I guess, you also wanted a fix for arch/s390/kvm/tests/instr_icpt/main.c in this series. > Thanks and happy hacking, > > Wolfram Thanks!
Powered by blists - more mailing lists