netdev - RE: [net-next 10/14] ptp: lan743x: convert to .adjfine and diff_by_scaled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CO1PR11MB508911401FEA7092B5C2D11CD6719@CO1PR11MB5089.namprd11.prod.outlook.com>
Date:   Mon, 22 Aug 2022 17:10:16 +0000
From:   "Keller, Jacob E" <jacob.e.keller@...el.com>
To:     lkp <lkp@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "llvm@...ts.linux.dev" <llvm@...ts.linux.dev>,
        "kbuild-all@...ts.01.org" <kbuild-all@...ts.01.org>,
        "K. Y. Srinivasan" <kys@...rosoft.com>,
        "Haiyang Zhang" <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Wei Liu <wei.liu@...nel.org>,
        "Cui, Dexuan" <decui@...rosoft.com>,
        "Tom Lendacky" <thomas.lendacky@....com>,
        Shyam Sundar S K <Shyam-sundar.S-k@....com>,
        Eric Dumazet <edumazet@...gle.com>,
        "Jakub Kicinski" <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "Siva Reddy Kallam" <siva.kallam@...adcom.com>,
        Prashant Sreedharan <prashant@...adcom.com>,
        Michael Chan <mchan@...adcom.com>,
        Yisen Zhuang <yisen.zhuang@...wei.com>,
        Salil Mehta <salil.mehta@...wei.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
        Tariq Toukan <tariqt@...dia.com>,
        "Saeed Mahameed" <saeedm@...dia.com>,
        Leon Romanovsky <leon@...nel.org>,
        "Bryan Whitehead" <bryan.whitehead@...rochip.com>,
        Sergey Shtylyov <s.shtylyov@....ru>,
        Giuseppe Cavallaro <peppe.cavallaro@...com>,
        "Alexandre Torgue" <alexandre.torgue@...s.st.com>,
        Jose Abreu <joabreu@...opsys.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Richard Cochran <richardcochran@...il.com>,
        "Thampi, Vivek" <vithampi@...are.com>
Subject: RE: [net-next 10/14] ptp: lan743x: convert to .adjfine and
 diff_by_scaled_ppm



> -----Original Message-----
> From: lkp <lkp@...el.com>
> Sent: Sunday, August 21, 2022 8:22 AM
> To: Keller, Jacob E <jacob.e.keller@...el.com>; netdev@...r.kernel.org
> Cc: llvm@...ts.linux.dev; kbuild-all@...ts.01.org; Keller, Jacob E
> <jacob.e.keller@...el.com>; K. Y. Srinivasan <kys@...rosoft.com>; Haiyang
> Zhang <haiyangz@...rosoft.com>; Stephen Hemminger
> <sthemmin@...rosoft.com>; Wei Liu <wei.liu@...nel.org>; Cui, Dexuan
> <decui@...rosoft.com>; Tom Lendacky <thomas.lendacky@....com>; Shyam
> Sundar S K <Shyam-sundar.S-k@....com>; Eric Dumazet
> <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni
> <pabeni@...hat.com>; Siva Reddy Kallam <siva.kallam@...adcom.com>;
> Prashant Sreedharan <prashant@...adcom.com>; Michael Chan
> <mchan@...adcom.com>; Yisen Zhuang <yisen.zhuang@...wei.com>; Salil
> Mehta <salil.mehta@...wei.com>; Brandeburg, Jesse
> <jesse.brandeburg@...el.com>; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; Tariq Toukan <tariqt@...dia.com>; Saeed
> Mahameed <saeedm@...dia.com>; Leon Romanovsky <leon@...nel.org>;
> Bryan Whitehead <bryan.whitehead@...rochip.com>; Sergey Shtylyov
> <s.shtylyov@....ru>; Giuseppe Cavallaro <peppe.cavallaro@...com>;
> Alexandre Torgue <alexandre.torgue@...s.st.com>; Jose Abreu
> <joabreu@...opsys.com>; Maxime Coquelin <mcoquelin.stm32@...il.com>;
> Richard Cochran <richardcochran@...il.com>; Thampi, Vivek
> <vithampi@...are.com>
> Subject: Re: [net-next 10/14] ptp: lan743x: convert to .adjfine and
> diff_by_scaled_ppm
> 
> Hi Jacob,
> 
> I love your patch! Yet something to improve:
> 
> [auto build test ERROR on 9017462f006c4b686cb1e1e1a3a52ea8363076e6]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Jacob-Keller/ptp-convert-
> drivers-to-adjfine/20220819-063154
> base:   9017462f006c4b686cb1e1e1a3a52ea8363076e6
> config: powerpc-allyesconfig (https://download.01.org/0day-
> ci/archive/20220821/202208212326.87xlsbQB-lkp@...el.com/config)
> compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project
> 01ffe31cbb54bfd8e38e71b3cf804a1d67ebf9c1)
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-
> tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # install powerpc cross compiling tool for clang build
>         # apt-get install binutils-powerpc-linux-gnu
>         # https://github.com/intel-lab-
> lkp/linux/commit/d3c6eac5778f2ce74e7d6d7be90a60f616551718
>         git remote add linux-review https://github.com/intel-lab-lkp/linux
>         git fetch --no-tags linux-review Jacob-Keller/ptp-convert-drivers-to-
> adjfine/20220819-063154
>         git checkout d3c6eac5778f2ce74e7d6d7be90a60f616551718
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1
> O=build_dir ARCH=powerpc SHELL=/bin/bash
> 
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@...el.com>
> 
> All errors (new ones prefixed by >>):
> 
> >> drivers/net/ethernet/microchip/lan743x_ptp.c:368:12: error: redefinition of
> 'lan743x_ptpci_adjfine'
>    static int lan743x_ptpci_adjfine(struct ptp_clock_info *ptpci, long delta)
>               ^
>    drivers/net/ethernet/microchip/lan743x_ptp.c:335:12: note: previous
> definition is here
>    static int lan743x_ptpci_adjfine(struct ptp_clock_info *ptpci, long scaled_ppm)
>               ^
> >> drivers/net/ethernet/microchip/lan743x_ptp.c:386:3: error: use of undeclared
> identifier 'lan743_rate_adj'; did you mean 'lan743x_rate_adj'?
>                    lan743_rate_adj = (u32)diff;
>                    ^~~~~~~~~~~~~~~
>                    lan743x_rate_adj
>    drivers/net/ethernet/microchip/lan743x_ptp.c:374:6: note: 'lan743x_rate_adj'
> declared here
>            u64 lan743x_rate_adj;
>                ^
> >> drivers/net/ethernet/microchip/lan743x_ptp.c:388:3: error: use of undeclared
> identifier 'lan74e_rage_adj'; did you mean 'lan743x_rate_adj'?
>                    lan74e_rage_adj = (u32)diff | PTP_CLOCK_RATE_ADJ_DIR_;
>                    ^~~~~~~~~~~~~~~
>                    lan743x_rate_adj
>    drivers/net/ethernet/microchip/lan743x_ptp.c:374:6: note: 'lan743x_rate_adj'
> declared here
>            u64 lan743x_rate_adj;
>                ^
>    3 errors generated.
> 
> 

I'll fix this in v2 once I get feedback for the rest of the patches.

Thanks,
Jake