netdev - Re: data-race in nf_tables_newtable / nf_tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220822204112.GA19050@breakpoint.cc>
Date:   Mon, 22 Aug 2022 22:41:12 +0200
From:   Florian Westphal <fw@...len.de>
To:     Gabriel Ryan <gabe@...columbia.edu>
Cc:     Florian Westphal <fw@...len.de>,
        Abhishek Shah <abhishek.shah@...umbia.edu>,
        coreteam@...filter.org, davem@...emloft.net, edumazet@...gle.com,
        kadlec@...filter.org, kuba@...nel.org, netdev@...r.kernel.org,
        netfilter-devel@...r.kernel.org, pabeni@...hat.com,
        pablo@...filter.org, linux-kernel@...r.kernel.org
Subject: Re: data-race in nf_tables_newtable / nf_tables_newtable

Gabriel Ryan <gabe@...columbia.edu> wrote:
> Hi Florian,
> 
> I just looked at the lock event trace from our report and it looks
> like two distinct commit mutexes were held when the race was
> triggered. I think the race is probably on the table_handle variable
> on net/netfilter/nf_tables_api.c:1221, and not the table->handle field
> being written to.

See

https://patchwork.ozlabs.org/project/netfilter-devel/patch/20220821085939.571378-1-pablo@netfilter.org/

which makes table_handle per netns.