netdev - Re: [RFC] r8152: pass through needs to be singular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <798b00fd-a888-5135-0396-f846eccc6510@suse.com>
Date:   Tue, 23 Aug 2022 09:53:07 +0200
From:   Oliver Neukum <oneukum@...e.com>
To:     Hayes Wang <hayeswang@...ltek.com>,
        Oliver Neukum <oneukum@...e.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [RFC] r8152: pass through needs to be singular



On 08.08.22 09:04, Hayes Wang wrote:
> Oliver Neukum <oneukum@...e.com>
>> Sent: Thursday, August 4, 2022 4:58 PM
> [...]
>>>> +	if (!holder_of_pass_through) {
>>>> +		ret = -EBUSY;
>>>> +		goto failout;
>>>> +	}
>>>
>>> Excuse me. I have one question.
>>> When is the holder_of_pass_through set?
>>> The default value of holder_of_pass_through is NULL, so
>>> it seems the holder_of_pass_through would never be set.
>>
>>
>> Hi,
>>
>> here in vendor_mac_passthru_addr_read()
> 
> I mean that holder_of_pass_through is NULL, so you set ret = -EBUSY and goto failout.
> However, holder_of_pass_through is set only if ret == 0. That is,
> holder_of_pass_through = tp would never occur, because ret is equal -EBUSY.
> The default value of holder_of_pass_through is NULL, so it has no chance to be set.
> Right?
>

Hi,

sorry, you are right. I made a "!" in error.
I'll correct that.

	Regards
		Oliver