netdev - Re: [PATCH net-next 1/2] ethtool: pass netlink extended ACK to .set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220823151354.4becbfe7@kernel.org>
Date:   Tue, 23 Aug 2022 15:13:54 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jacob Keller <jacob.e.keller@...el.com>
Cc:     netdev@...r.kernel.org, Michael Chan <michael.chan@...adcom.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Derek Chickles <dchickles@...vell.com>,
        Satanand Burla <sburla@...vell.com>,
        Felix Manlunas <fmanlunas@...vell.com>,
        Raju Rangoju <rajur@...lsio.com>,
        Dimitris Michailidis <dmichail@...gible.com>,
        Yisen Zhuang <yisen.zhuang@...wei.com>,
        Salil Mehta <salil.mehta@...wei.com>,
        Jesse Brandeburg <jesse.brandeburg@...el.com>,
        Tony Nguyen <anthony.l.nguyen@...el.com>,
        Sunil Goutham <sgoutham@...vell.com>,
        Geetha sowjanya <gakula@...vell.com>,
        Subbaraya Sundeep <sbhatta@...vell.com>,
        hariprasad <hkelam@...vell.com>,
        Taras Chornyi <tchornyi@...vell.com>,
        Saeed Mahameed <saeedm@...dia.com>,
        Leon Romanovsky <leon@...nel.org>,
        Simon Horman <simon.horman@...igine.com>,
        Shannon Nelson <snelson@...sando.io>,
        Ariel Elior <aelior@...vell.com>,
        Manish Chopra <manishc@...vell.com>,
        Edward Cree <ecree.xilinx@...il.com>,
        Martin Habets <habetsm.xilinx@...il.com>,
        Fei Qin <fei.qin@...igine.com>,
        Louis Peens <louis.peens@...igine.com>,
        Yu Xiao <yu.xiao@...igine.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, Yufeng Mo <moyufeng@...wei.com>,
        Sixiang Chen <sixiang.chen@...igine.com>,
        Yinjun Zhang <yinjun.zhang@...igine.com>,
        Hao Chen <chenhao288@...ilicon.com>,
        Guangbin Huang <huangguangbin2@...wei.com>,
        Sean Anderson <sean.anderson@...o.com>,
        Erik Ekman <erik@...o.se>, Ido Schimmel <idosch@...dia.com>,
        Jie Wang <wangjie125@...wei.com>,
        Moshe Tal <moshet@...dia.com>,
        Tonghao Zhang <xiangxia.m.yue@...il.com>,
        Marco Bonelli <marco@...eim.net>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>
Subject: Re: [PATCH net-next 1/2] ethtool: pass netlink extended ACK to
 .set_fecparam

On Tue, 23 Aug 2022 08:04:37 -0700 Jacob Keller wrote:
> Add the netlink extended ACK structure pointer to the interface for
> .set_fecparam. This allows reporting errors to the user appropriately when
> using the netlink ethtool interface.

Could you wrap it into a structure perhaps?

Would be good if we didn't have to modify the signature of the callback
next time we need to extend it (especially since struct ethtool_fecparam
is ioctl uABI so we can't really add fields there).