netdev - Re: [EXTERNAL] [PATCH net-next] net: ethernet: ti: davinci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54b0435b-3aa6-d6c7-9411-818205b9ac71@ti.com>
Date:   Wed, 24 Aug 2022 10:37:14 +0530
From:   Ravi Gunasekaran <r-gunasekaran@...com>
To:     Randy Dunlap <rdunlap@...radead.org>, <netdev@...r.kernel.org>
CC:     Grygorii Strashko <grygorii.strashko@...com>,
        <linux-omap@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Naresh Kamboju <naresh.kamboju@...aro.org>,
        Sudip Mukherjee <sudipm.mukherjee@...il.com>
Subject: Re: [EXTERNAL] [PATCH net-next] net: ethernet: ti: davinci_mdio: fix
 build for mdio bitbang uses

Hi Randy,


On 24/08/22 8:12 am, Randy Dunlap wrote:
> davinci_mdio.c uses mdio bitbang APIs, so it should select
> MDIO_BITBANG to prevent build errors.
> 
> arm-linux-gnueabi-ld: drivers/net/ethernet/ti/davinci_mdio.o: in function `davinci_mdio_remove':
> drivers/net/ethernet/ti/davinci_mdio.c:649: undefined reference to `free_mdio_bitbang'
> arm-linux-gnueabi-ld: drivers/net/ethernet/ti/davinci_mdio.o: in function `davinci_mdio_probe':
> drivers/net/ethernet/ti/davinci_mdio.c:545: undefined reference to `alloc_mdio_bitbang'
> arm-linux-gnueabi-ld: drivers/net/ethernet/ti/davinci_mdio.o: in function `davinci_mdiobb_read':
> drivers/net/ethernet/ti/davinci_mdio.c:236: undefined reference to `mdiobb_read'
> arm-linux-gnueabi-ld: drivers/net/ethernet/ti/davinci_mdio.o: in function `davinci_mdiobb_write':
> drivers/net/ethernet/ti/davinci_mdio.c:253: undefined reference to `mdiobb_write'
> 
> Fixes: d04807b80691 ("net: ethernet: ti: davinci_mdio: Add workaround for errata i2329")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Grygorii Strashko <grygorii.strashko@...com>
> Cc: Ravi Gunasekaran <r-gunasekaran@...com>
> Cc: linux-omap@...r.kernel.org
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Paolo Abeni <pabeni@...hat.com>
> Cc: Naresh Kamboju <naresh.kamboju@...aro.org>
> Cc: Sudip Mukherjee (Codethink) <sudipm.mukherjee@...il.com>
> ---
>   drivers/net/ethernet/ti/Kconfig |    1 +
>   1 file changed, 1 insertion(+)
> 
> --- a/drivers/net/ethernet/ti/Kconfig
> +++ b/drivers/net/ethernet/ti/Kconfig
> @@ -33,6 +33,7 @@ config TI_DAVINCI_MDIO
>   	tristate "TI DaVinci MDIO Support"
>   	depends on ARCH_DAVINCI || ARCH_OMAP2PLUS || ARCH_KEYSTONE || ARCH_K3 || COMPILE_TEST
>   	select PHYLIB
> +	select MDIO_BITBANG
>   	help
>   	  This driver supports TI's DaVinci MDIO module.
>   
Thanks for posting this patch before me.

-- 
Regards,
Ravi