netdev - Re: [PATCH net-next v2 6/6] ethtool: report missing header via ext

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ywdotl9Zn2MlBhCF@shredder>
Date:   Thu, 25 Aug 2022 15:19:02 +0300
From:   Ido Schimmel <idosch@...dia.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
        pabeni@...hat.com, mkubecek@...e.cz, johannes@...solutions.net
Subject: Re: [PATCH net-next v2 6/6] ethtool: report missing header via
 ext_ack in the default handler

On Wed, Aug 24, 2022 at 07:41:22PM -0700, Jakub Kicinski wrote:
> The actual presence check for the header is in
> ethnl_parse_header_dev_get() but it's a few layers in,
> and already has a ton of arguments so let's just pick
> the low handing fruit and check for missing header in

s/handing/hanging/

> the default request handler.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: idosch@...dia.com

Reviewed-by: Ido Schimmel <idosch@...dia.com>

Nice idea. Wanted to ask why you kept the error messages for some of the
devlink attributes, but then I figured that user space first needs to
learn to interpret 'NLMSGERR_ATTR_MISS_TYPE' and
'NLMSGERR_ATTR_MISS_NEST'. Do you plan to patch iproute2/ethtool after
the kernel patches are accepted?