lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 25 Aug 2022 13:35:01 -0700 From: Hao Luo <haoluo@...gle.com> To: Andrii Nakryiko <andrii.nakryiko@...il.com> Cc: linux-kernel@...r.kernel.org, bpf@...r.kernel.org, cgroups@...r.kernel.org, netdev@...r.kernel.org, Alexei Starovoitov <ast@...nel.org>, Andrii Nakryiko <andrii@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Martin KaFai Lau <martin.lau@...ux.dev>, Song Liu <song@...nel.org>, Yonghong Song <yhs@...com>, Tejun Heo <tj@...nel.org>, Zefan Li <lizefan.x@...edance.com>, KP Singh <kpsingh@...nel.org>, Johannes Weiner <hannes@...xchg.org>, Michal Hocko <mhocko@...nel.org>, John Fastabend <john.fastabend@...il.com>, Jiri Olsa <jolsa@...nel.org>, Michal Koutny <mkoutny@...e.com>, Roman Gushchin <roman.gushchin@...ux.dev>, David Rientjes <rientjes@...gle.com>, Stanislav Fomichev <sdf@...gle.com>, Shakeel Butt <shakeelb@...gle.com>, Yosry Ahmed <yosryahmed@...gle.com> Subject: Re: [PATCH bpf-next v9 1/5] bpf: Introduce cgroup iter On Thu, Aug 25, 2022 at 1:18 PM Andrii Nakryiko <andrii.nakryiko@...il.com> wrote: > > On Tue, Aug 23, 2022 at 8:01 PM Hao Luo <haoluo@...gle.com> wrote: > > [...] > > typedef int (*bpf_iter_attach_target_t)(struct bpf_prog *prog, > > diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h > > index 934a2a8beb87..1c4e1c583880 100644 > > --- a/include/uapi/linux/bpf.h > > +++ b/include/uapi/linux/bpf.h > > @@ -87,10 +87,29 @@ struct bpf_cgroup_storage_key { > > __u32 attach_type; /* program attach type (enum bpf_attach_type) */ > > }; > > > > +enum bpf_cgroup_iter_order { > > + BPF_ITER_ORDER_UNSPEC = 0, > > + BPF_ITER_SELF_ONLY, /* process only a single object. */ > > + BPF_ITER_DESCENDANTS_PRE, /* walk descendants in pre-order. */ > > + BPF_ITER_DESCENDANTS_POST, /* walk descendants in post-order. */ > > + BPF_ITER_ANCESTORS_UP, /* walk ancestors upward. */ > > +}; > > just skimming through this, I noticed that we have "enum > bpf_cgroup_iter_order" (good, I like) but BPF_ITER_xxx with no CGROUP > part in it (not good, don't like :). All the enumerator names have > global visibility, so it would probably be best for them to be > CGROUP-specific and roughly match the enum name itself: > BPF_CGROUP_ITER_SELF_ONLY, etc? > Ack. I will send a patch to fix this right now.
Powered by blists - more mailing lists