netdev - Re: [PATCH net-next 1] net: ngbe: Add build support for ngbe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YwfltvdQaHUNKdAh@lunn.ch>
Date:   Thu, 25 Aug 2022 23:12:22 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Mengyuan Lou <mengyuanlou@...-swift.com>
Cc:     netdev@...r.kernel.org, jiawenwu@...stnetic.com
Subject: Re: [PATCH net-next 1] net: ngbe: Add build support for ngbe

> +++ b/drivers/net/ethernet/wangxun/Kconfig
> @@ -16,6 +16,19 @@ config NET_VENDOR_WANGXUN
>  
>  if NET_VENDOR_WANGXUN
>  
> +config NGBE
> +	tristate "Wangxun(R) GbE PCI Express adapters support"
> +	depends on PCI

> +++ b/drivers/net/ethernet/wangxun/Makefile
> @@ -4,3 +4,4 @@
>  #
>  
>  obj-$(CONFIG_TXGBE) += txgbe/
> +obj-$(CONFIG_TXGBE) += ngbe/

I think this should be NGBE, not TXGBE.

> +/* ngbe_pci_tbl - PCI Device ID Table
> + *
> + * Wildcard entries (PCI_ANY_ID) should come last

You make this comment, but then don't have a wildcard?

> + * Last entry must be all 0s
> + *
> + * { Vendor ID, Device ID, SubVendor ID, SubDevice ID,
> + *   Class, Class Mask, private data (not used) }
> + */
> +static const struct pci_device_id ngbe_pci_tbl[] = {
> +	{ PCI_VDEVICE(WANGXUN, NGBE_DEV_ID_EM_WX1860AL_W), 0},
> +	{ PCI_VDEVICE(WANGXUN, NGBE_DEV_ID_EM_WX1860A2), 0},
> +	{ PCI_VDEVICE(WANGXUN, NGBE_DEV_ID_EM_WX1860A2S), 0},
> +	{ PCI_VDEVICE(WANGXUN, NGBE_DEV_ID_EM_WX1860A4), 0},
> +	{ PCI_VDEVICE(WANGXUN, NGBE_DEV_ID_EM_WX1860A4S), 0},
> +	{ PCI_VDEVICE(WANGXUN, NGBE_DEV_ID_EM_WX1860AL2), 0},
> +	{ PCI_VDEVICE(WANGXUN, NGBE_DEV_ID_EM_WX1860AL2S), 0},
> +	{ PCI_VDEVICE(WANGXUN, NGBE_DEV_ID_EM_WX1860AL4), 0},
> +	{ PCI_VDEVICE(WANGXUN, NGBE_DEV_ID_EM_WX1860AL4S), 0},
> +	{ PCI_VDEVICE(WANGXUN, NGBE_DEV_ID_EM_WX1860LC), 0},
> +	{ PCI_VDEVICE(WANGXUN, NGBE_DEV_ID_EM_WX1860A1), 0},
> +	{ PCI_VDEVICE(WANGXUN, NGBE_DEV_ID_EM_WX1860A1L), 0},
> +	/* required last entry */
> +	{ .device = 0 }
> +};
> +

You can add my Reviewed-by: Andrew Lunn <andrew@...n.ch>
when you fix up these two minor issues.

	Andrew