netdev - Re: [PATCH net-next v4 2/3] net: skb: use auto-generation to convert skb drop reason to string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADxym3bC8=cLp4_n9OTQpV_Hw=XuTZySr96RrahQXfAKt0q2=g@mail.gmail.com>
Date:   Thu, 25 Aug 2022 10:29:25 +0800
From:   Menglong Dong <menglong8.dong@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>
Cc:     Steven Rostedt <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...hat.com>,
        David Miller <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        Neil Horman <nhorman@...driver.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Menglong Dong <imagedong@...cent.com>,
        David Ahern <dsahern@...nel.org>,
        Talal Ahmad <talalahmad@...gle.com>,
        Kees Cook <keescook@...omium.org>,
        LKML <linux-kernel@...r.kernel.org>,
        netdev <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH net-next v4 2/3] net: skb: use auto-generation to convert
 skb drop reason to string

On Thu, Aug 25, 2022 at 9:10 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Wed, 24 Aug 2022 17:45:15 -0700 Eric Dumazet wrote:
> > After this patch, I no longer have strings added after the reason: tag
>
> Hm, using a kernel address (drop_reasons) as an argument to TP_printk()
> definitely does not look right, but how to tickle whatever magic
> __print_symbolic was providing I do not know :S
>
>         TP_printk("skbaddr=%p protocol=%u location=%p reason: %s",
>                   __entry->skbaddr, __entry->protocol, __entry->location,
> -                 __print_symbolic(__entry->reason,
> -                                  TRACE_SKB_DROP_REASON))
> +                 drop_reasons[__entry->reason])

it seems that TP_printk is not as simple as I thought.......

Sorry for the problem I brought, I'm looking for a solution.

Thanks!
Menglong Dong