netdev - RE: [EXT] Re: [PATCH V2] octeontx2-pf: Add egress PFC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SJ0PR18MB5216A5964361E85196109BBEDB729@SJ0PR18MB5216.namprd18.prod.outlook.com>
Date:   Thu, 25 Aug 2022 04:42:54 +0000
From:   Suman Ghosh <sumang@...vell.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        Linu Cherian <lcherian@...vell.com>,
        Geethasowjanya Akula <gakula@...vell.com>,
        Jerin Jacob Kollanukkaran <jerinj@...vell.com>,
        Hariprasad Kelam <hkelam@...vell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [EXT] Re: [PATCH V2] octeontx2-pf: Add egress PFC support

>External Email
>
>----------------------------------------------------------------------
>On Wed, 24 Aug 2022 11:30:06 +0530 Suman Ghosh wrote:
>> As of now all transmit queues transmit packets out of same scheduler
>> queue hierarchy. Due to this PFC frames sent by peer are not handled
>> properly, either all transmit queues are backpressured or none.
>> To fix this when user enables PFC for a given priority map relavant
>> transmit queue to a different scheduler queue hierarcy, so that
>> backpressure is applied only to the traffic egressing out of that TXQ.
>
>clang says:
>
>drivers/net/ethernet/marvell/octeontx2/nic/otx2_dcbnl.c:129:6: warning:
>variable 'err' set but not used [-Wunused-but-set-variable]
>        int err;
>            ^
[Suman] Fixed in patch V3