netdev - Re: [PATCH net-next v2 2/6] netlink: add support for ext

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3950b10724620f23e3e84ec2686e5e6ac6fa5e0f.camel@sipsolutions.net>
Date:   Thu, 25 Aug 2022 08:49:21 +0200
From:   Johannes Berg <johannes@...solutions.net>
To:     Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com,
        mkubecek@...e.cz, corbet@....net, jacob.e.keller@...el.com,
        fw@...len.de, razor@...ckwall.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH net-next v2 2/6] netlink: add support for ext_ack
 missing attributes

On Wed, 2022-08-24 at 19:41 -0700, Jakub Kicinski wrote:
> 
> + * @miss_type: attribute type which was missing
> + * @miss_nest: nest missing an attribute (NULL if missing top level attr)

nit: maybe use %NULL for appropriate formatting in generated
documentation

>  	const char *_msg;
>  	const struct nlattr *bad_attr;
>  	const struct nla_policy *policy;
> +	const void *miss_nest;

Can be 'const struct nlattr *' now, no? No longer points to a random
header.

johannes