netdev - Re: [PATCH v2 net 1/1] rose: check NULL rose_loopback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YwgNoB2DXdx2+gLI@electric-eye.fr.zoreil.com>
Date:   Fri, 26 Aug 2022 02:02:40 +0200
From:   Francois Romieu <romieu@...zoreil.com>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     netdev <netdev@...r.kernel.org>, linux-hams@...r.kernel.org,
        Bernard <bernard.f6bvp@...il.com>,
        Bernard Pidoux <f6bvp@...e.fr>,
        Thomas Osterried <thomas@...erried.de>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH v2 net 1/1] rose: check NULL rose_loopback_neigh->loopback

Eric Dumazet <edumazet@...gle.com> :
[...]
> ok but then the original crash/bug reappears....

When the fuzzer runs, the system does not notice that something goes
wrong until rose_find_listener() returns NULL in rose_rx_call_request
whereas Bernard's connect passes this test.

Testing both sk == NULL and !neigh->dev after rose_find_listener may
work but it looks like an ugly bandaid.

Good night.

-- 
Ueimor