netdev - RE: [EXT] Re: [net-next PATCH V3] octeontx2-pf: Add egress PFC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SJ0PR18MB52167EC10DD811D6AB79A532DB759@SJ0PR18MB5216.namprd18.prod.outlook.com>
Date:   Fri, 26 Aug 2022 08:12:24 +0000
From:   Suman Ghosh <sumang@...vell.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        Linu Cherian <lcherian@...vell.com>,
        Geethasowjanya Akula <gakula@...vell.com>,
        Jerin Jacob Kollanukkaran <jerinj@...vell.com>,
        Hariprasad Kelam <hkelam@...vell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [EXT] Re: [net-next PATCH V3] octeontx2-pf: Add egress PFC
 support

>>External Email
>>
>>----------------------------------------------------------------------
>>On Thu, 25 Aug 2022 10:12:42 +0530 Suman Ghosh wrote:
>>> As of now all transmit queues transmit packets out of same scheduler
>>> queue hierarchy. Due to this PFC frames sent by peer are not handled
>>> properly, either all transmit queues are backpressured or none.
>>> To fix this when user enables PFC for a given priority map relavant
>>> transmit queue to a different scheduler queue hierarcy, so that
>>> backpressure is applied only to the traffic egressing out of that
>TXQ.
>>
>>Does not build at all now:
>>
>>ERROR: modpost: drivers/net/ethernet/marvell/octeontx2/nic/rvu_nicvf:
>>'otx2_pfc_txschq_update' exported twice. Previous export was in
>>drivers/net/ethernet/marvell/octeontx2/nic/rvu_nicpf.ko
>>ERROR: modpost: "otx2_txschq_config"
>>[drivers/net/ethernet/marvell/octeontx2/nic/rvu_nicvf.ko] undefined!
>>ERROR: modpost: "otx2_smq_flush"
>>[drivers/net/ethernet/marvell/octeontx2/nic/rvu_nicvf.ko] undefined!
>[Suman] Sorry my bad. Updated the patch with the fix.
[Suman] It had another error. I have pushed V5 and compilation is working with this patch