netdev - Re: [patch net-next] net: devlink: stub port params cmds for they are unused internally

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YwiBcYvUejIJ99ne@nanopsycho>
Date:   Fri, 26 Aug 2022 10:16:49 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, pabeni@...hat.com,
        edumazet@...gle.com
Subject: Re: [patch net-next] net: devlink: stub port params cmds for they
 are unused internally

Fri, Aug 26, 2022 at 03:11:37AM CEST, kuba@...nel.org wrote:
>On Thu, 25 Aug 2022 10:26:28 +0200 Jiri Pirko wrote:
>> From: Jiri Pirko <jiri@...dia.com>
>> 
>> Follow-up the removal of unused internal api of port params made by
>> commit 42ded61aa75e ("devlink: Delete not used port parameters APIs")
>> and stub the commands and add extack message to tell the user what is
>> going on.
>> 
>> If later on port params are needed, could be easily re-introduced,
>> but until then it is a dead code.
>> 
>> Signed-off-by: Jiri Pirko <jiri@...dia.com>
>
>Why no extack on the dump, tho? Wouldn't iproute2 do dumps mostly?

Okay, will add that.

>
>With that answered/addressed:
>
>Reviewed-by: Jakub Kicinski <kuba@...nel.org>