lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <MW4PR11MB577639450F79C109465BC48CFD759@MW4PR11MB5776.namprd11.prod.outlook.com> Date: Fri, 26 Aug 2022 11:52:06 +0000 From: "Drewek, Wojciech" <wojciech.drewek@...el.com> To: Jiri Pirko <jiri@...nulli.us> CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Lobakin, Alexandr" <alexandr.lobakin@...el.com>, "Brandeburg, Jesse" <jesse.brandeburg@...el.com>, "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>, "jhs@...atatu.com" <jhs@...atatu.com>, "xiyou.wangcong@...il.com" <xiyou.wangcong@...il.com>, "marcin.szycik@...ux.intel.com" <marcin.szycik@...ux.intel.com>, "michal.swiatkowski@...ux.intel.com" <michal.swiatkowski@...ux.intel.com>, "kurt@...utronix.de" <kurt@...utronix.de>, "boris.sukholitko@...adcom.com" <boris.sukholitko@...adcom.com>, "vladbu@...dia.com" <vladbu@...dia.com>, "komachi.yoshiki@...il.com" <komachi.yoshiki@...il.com>, "paulb@...dia.com" <paulb@...dia.com>, "baowen.zheng@...igine.com" <baowen.zheng@...igine.com>, "louis.peens@...igine.com" <louis.peens@...igine.com>, "simon.horman@...igine.com" <simon.horman@...igine.com>, "pablo@...filter.org" <pablo@...filter.org>, "maksym.glubokiy@...ision.eu" <maksym.glubokiy@...ision.eu>, "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>, "jchapman@...alix.com" <jchapman@...alix.com>, "gnault@...hat.com" <gnault@...hat.com> Subject: RE: [RFC PATCH net-next 0/5] ice: L2TPv3 offload support > -----Original Message----- > From: Drewek, Wojciech > Sent: piątek, 26 sierpnia 2022 13:37 > To: Jiri Pirko <jiri@...nulli.us> > Cc: netdev@...r.kernel.org; Lobakin, Alexandr <alexandr.lobakin@...el.com>; Brandeburg, Jesse <jesse.brandeburg@...el.com>; > Nguyen, Anthony L <anthony.l.nguyen@...el.com>; davem@...emloft.net; edumazet@...gle.com; kuba@...nel.org; > pabeni@...hat.com; jhs@...atatu.com; xiyou.wangcong@...il.com; marcin.szycik@...ux.intel.com; > michal.swiatkowski@...ux.intel.com; kurt@...utronix.de; boris.sukholitko@...adcom.com; vladbu@...dia.com; > komachi.yoshiki@...il.com; paulb@...dia.com; baowen.zheng@...igine.com; louis.peens@...igine.com; > simon.horman@...igine.com; pablo@...filter.org; maksym.glubokiy@...ision.eu; intel-wired-lan@...ts.osuosl.org; > jchapman@...alix.com; gnault@...hat.com > Subject: RE: [RFC PATCH net-next 0/5] ice: L2TPv3 offload support > > > > > -----Original Message----- > > From: Jiri Pirko <jiri@...nulli.us> > > Sent: piątek, 26 sierpnia 2022 13:16 > > To: Drewek, Wojciech <wojciech.drewek@...el.com> > > Cc: netdev@...r.kernel.org; Lobakin, Alexandr <alexandr.lobakin@...el.com>; Brandeburg, Jesse <jesse.brandeburg@...el.com>; > > Nguyen, Anthony L <anthony.l.nguyen@...el.com>; davem@...emloft.net; edumazet@...gle.com; kuba@...nel.org; > > pabeni@...hat.com; jhs@...atatu.com; xiyou.wangcong@...il.com; marcin.szycik@...ux.intel.com; > > michal.swiatkowski@...ux.intel.com; kurt@...utronix.de; boris.sukholitko@...adcom.com; vladbu@...dia.com; > > komachi.yoshiki@...il.com; paulb@...dia.com; baowen.zheng@...igine.com; louis.peens@...igine.com; > > simon.horman@...igine.com; pablo@...filter.org; maksym.glubokiy@...ision.eu; intel-wired-lan@...ts.osuosl.org; > > jchapman@...alix.com; gnault@...hat.com > > Subject: Re: [RFC PATCH net-next 0/5] ice: L2TPv3 offload support > > > > Fri, Aug 26, 2022 at 01:00:54PM CEST, wojciech.drewek@...el.com wrote: > > >Add support for dissecting L2TPv3 session id in flow dissector. Add support > > >for this field in tc-flower and support offloading L2TPv3. Finally, add > > >support for hardware offload of L2TPv3 packets based on session id in > > >switchdev mode in ice driver. > > > > > >Example filter: > > > # tc filter add dev $PF1 ingress prio 1 protocol ip \ > > > flower \ > > > ip_proto l2tp \ > > > l2tpv3_sid 1234 \ > > > skip_sw \ > > > action mirred egress redirect dev $VF1_PR > > > > > >Changes in iproute2 are required to use the new fields. > > > > > >ICE COMMS DDP package is required to create a filter in ice. > > > > I don't understand what do you mean by this. Could you please explain > > what this mysterious "ICE COMMS DDP package" is? Do I understand it > > correctly that without it, the solution would not work? > > Sorry, I'll include more precise description in the next version. > DDP (Dynamic Device Personalization) is a firmware package that contains definitions > protocol's headers and packets. It allows you to add support for the new protocol to the > NIC card without rebooting. If the DDP package does not support L2TPv3 then hw offload > will not work, however sw offload will still work. > > More info on DDP: > https://www.intel.com/content/www/us/en/architecture-and-technology/ethernet/dynamic-device-personalization-brief.html To be more precise we need COMMS DDP package that supports more protocols (L2TPv3 included): https://www.intel.com/content/www/us/en/download/19660/intel-ethernet-800-series-telecommunication-comms-dynamic-device-personalization-ddp-package.html > > > > > > > > >Marcin Szycik (1): > > > ice: Add L2TPv3 hardware offload support > > > > > >Wojciech Drewek (4): > > > uapi: move IPPROTO_L2TP to in.h > > > flow_dissector: Add L2TPv3 dissectors > > > net/sched: flower: Add L2TPv3 filter > > > flow_offload: Introduce flow_match_l2tpv3 > > > > > > .../ethernet/intel/ice/ice_protocol_type.h | 8 +++ > > > drivers/net/ethernet/intel/ice/ice_switch.c | 70 ++++++++++++++++++- > > > drivers/net/ethernet/intel/ice/ice_tc_lib.c | 27 ++++++- > > > drivers/net/ethernet/intel/ice/ice_tc_lib.h | 6 ++ > > > include/net/flow_dissector.h | 9 +++ > > > include/net/flow_offload.h | 6 ++ > > > include/uapi/linux/in.h | 2 + > > > include/uapi/linux/l2tp.h | 2 - > > > include/uapi/linux/pkt_cls.h | 2 + > > > net/core/flow_dissector.c | 28 ++++++++ > > > net/core/flow_offload.c | 7 ++ > > > net/sched/cls_flower.c | 16 +++++ > > > 12 files changed, 179 insertions(+), 4 deletions(-) > > > > > >-- > > >2.31.1 > > >
Powered by blists - more mailing lists