netdev - Re: Not getting ICMP reports from the UDP socket in rxrpc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2764878.1661521182@warthog.procyon.org.uk>
Date:   Fri, 26 Aug 2022 14:39:42 +0100
From:   David Howells <dhowells@...hat.com>
To:     unlisted-recipients:; (no To-header on input)
Cc:     dhowells@...hat.com, Eric Dumazet <edumazet@...gle.com>,
        David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: Not getting ICMP reports from the UDP socket in rxrpc

David Howells <dhowells@...hat.com> wrote:

> Do you know if ICMP handling has changed inside of ipv4/ipv6?  I've realised
> that though rxrpc tries to get ICMP events, they're not coming through.
> 
> rxrpc_open_socket() does:
> 
> 	usk->sk_error_report = rxrpc_error_report;
> 
> to set the error collector and:
> 
> 		ip6_sock_set_recverr(usk);
> 		ip_sock_set_recverr(usk);
> 
> as appropriate to say that it wants to get ICMP messages, but they don't seem
> to come.  I put a printk() into sk_error_report(), but I don't see anything
> printed when ICMP messages come in (but I do if I telnet to a random port on
> my test server).

Ah... there's a separate error handling hook (encap_err_lookup) for tunnels.
I guess I need that.  Do you know if only ICMP/ICMP6 messages go through that
and not other SO_EE_ORIGIN_* types?

David