netdev - RE: [iproute2-next v3 2/3] mnlg: add function to get CTRL_ATTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO1PR11MB50890D5A3470D9921711A91AD6759@CO1PR11MB5089.namprd11.prod.outlook.com>
Date:   Fri, 26 Aug 2022 00:40:20 +0000
From:   "Keller, Jacob E" <jacob.e.keller@...el.com>
To:     Jiri Pirko <jiri@...nulli.us>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jonathan Corbet <corbet@....net>, Jiri Pirko <jiri@...dia.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
        David Ahern <dsahern@...nel.org>,
        "Stephen Hemminger" <stephen@...workplumber.org>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>
Subject: RE: [iproute2-next v3 2/3] mnlg: add function to get
 CTRL_ATTR_MAXATTR value



> -----Original Message-----
> From: Jiri Pirko <jiri@...nulli.us>
> Sent: Tuesday, July 26, 2022 12:47 AM
> To: Keller, Jacob E <jacob.e.keller@...el.com>
> Cc: netdev@...r.kernel.org; Jonathan Corbet <corbet@....net>; Jiri Pirko
> <jiri@...dia.com>; David S. Miller <davem@...emloft.net>; Eric Dumazet
> <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni
> <pabeni@...hat.com>; Nguyen, Anthony L <anthony.l.nguyen@...el.com>;
> David Ahern <dsahern@...nel.org>; Stephen Hemminger
> <stephen@...workplumber.org>; linux-doc@...r.kernel.org
> Subject: Re: [iproute2-next v3 2/3] mnlg: add function to get
> CTRL_ATTR_MAXATTR value
> 
> Mon, Jul 25, 2022 at 10:56:49PM CEST, jacob.e.keller@...el.com wrote:
> >Add a new function to extract the CTRL_ATTR_MAXATTR attribute of the
> >CTRL_CMD_GETFAMILY request. This will be used to allow reading the
> >maximum supported devlink attribute of the running kernel in an upcoming
> >change.
> >
> >Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
> 
> Reviewed-by: Jiri Pirko <jiri@...dia.com>

I had a new approach which just extracted maxattr and stored it hwnever we call CTRL_CMD_GETFAMILY, which I think is a preferable approach to this. That was part of the series I sent recently to support policy checking. I think I'd prefer that route now over this patch.

Thanks,
Jake