netdev - Re: [PATCH] tg3: Disable tg3 device on system reboot to avoid triggering AER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAd53p78YwD2bcrQeoH7gg4D=Jk5LYBEbj7boMOQFn2LAh8qUA@mail.gmail.com>
Date:   Fri, 26 Aug 2022 10:33:03 +0800
From:   Kai-Heng Feng <kai.heng.feng@...onical.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     siva.kallam@...adcom.com, prashant@...adcom.com,
        mchan@...adcom.com, Josef Bacik <josef@...icpanda.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tg3: Disable tg3 device on system reboot to avoid
 triggering AER

On Fri, Aug 26, 2022 at 1:44 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Thu, 25 Aug 2022 14:38:52 +0800 Kai-Heng Feng wrote:
> >       rtnl_lock();
> > +
> > +     tg3_reset_task_cancel(tp);
>
> Doesn't this "task" take rtnl_lock()? Looks deadlocky.

Thanks for the review. I sent v2 to address it.

Kai-Heng